41515 - Mozilla menus need Access &Keys

Status: VERIFIED WORKSFORME

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[timeless]

2000060320
Tasks menu doesn't have access keys.  will attach diff for the two files .dtd 
and .xul

Comment 1

[timeless]

Attachment: diffs for tasksOverlay.dtd and tasksOverlay.xul to add access keys

Comment 2

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I do not know if timeless got me message on IRC, so here it is:

If you have a fix for this specific bug, please attach the patch here.

If you have identified another bug (for example Implement Access Keys), make 
that a new bug. Even if the new bug logically includes this bug. This is an 
opinion issue, but I think QA especially would like to have more small bugs than 
few issues covering lots of ground.

A word of warning on a general bug, like Implement Access Keys: it is really 
difficult to close such bugs. New stuff just keeps on popping up. For example, I 
had a bug "Implement simple XLink". Eventually I had to close the bug and open 
new bugs that really were subsets of that bug.

Comment 3

[timeless]

Attachment: Access keys for Mail News, and Tasks: PSM and Chatzilla

Comment 4

[timeless]

Changing subject because i've decided to just attach all of my access key 
patches to one bug.

Comment 5

[Brendan Donohoe]

Lake, this is your department...

Comment 6

[Matthew T (active 1999-2002)]

Careful now timeless, don't just pick access keys at random on the assumption 
that anything is better than nothing. Because if it's discovered later that a 
different access key makes more sense for a particular item, then users will have 
some relearning to do (and some mistakes to make).

When picking access keys you need to take into account the following:
* obviousness (e.g. the letter a word starts or ends with)
* consistency with other apps (check the access keys on Word or a similar
  well-established app)
* consistency between components (e.g. if a particular item does something rather
  destructive in Messenger, you possibly shouldn't use the same access key in the
  same menu for something trivial in Navigator)
* consistency with previous versions of Mozilla
* speed, with particular regard to the QWERTY keyboard (e.g. for the most
  commonly used item in a menu, having the access key for the item and the access
  key for the menu itself close to each other on the keyboard -- or even the same
  character, if possible -- is usually a good thing)
* localizability (e.g. `n' is usually a good choice for a negative menu item).

Might be a good idea to see if you can get Lake or someone to give you a spec of 
what the keys should be.

Comment 7

[Lakespur Roca]

Nominating Beta3 - Pollish

Comment 8

[Alec Flett]

adding myself to CC
I'm working with jglick and sol to get the menu specs put on mozilla.org.
I've got diffs that I'm going to checkin for timeless, for mail. I think
something is better than nothing for beta - people relearning stuff that they
learned in a beta is fine. 

Once the specs are outside the firewall, timeless can send a new patch with the
updated access keys.

Comment 9

[hangas]

marking nsbeta3- while lake has this bug

Comment 10

[timeless]

Attachment: Add access key to for Privacy and Security>&Security Manager

Comment 11

[timeless]

Taking bug

Comment 12

[timeless]

Attachment: Add access key to for Privacy and Security>&Security Manager

Comment 13

[timeless]

this latest attachment removes
mozilla/xpfe/global/resources/locale/en-US/PSMTaskMenu.dtd
which I suspect was missed by bryner when he did a mass move ~Sep 21 21:42 
~Moving files out of security/base at request of security team. The new home 
for these files is into netwerk.~ Bug 53648.

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

looks ok.
a=[e-mail] for the security changes. 

Comment 15

[timeless]

That fix checked in a=ben, r=blake. Sorry about the lacking bonsai query.

Comment 16

[Matthew T (active 1999-2002)]

[--> XP Apps: GUI]

Comment 17

[Chris McAfee]

This looks fixed to me, please reopen if I have overlooked something.

Comment 18

[sairuh (rarely reading bugmail)]

mass verification of WorksForMe bugs: to find all bugspam pertaining to this,
set your search string to "IfItWorksForSlappyTheSquirrelThenItWFM".

if you think this particular bug is *still* an open issue, please make sure of
the following before reopening:

a. that it's still a problem with ***recent trunk builds*** on the all
appropriate platform[s]

b. provide clear steps to reproduce (unless a good test case is already in the
bug report), making sure it pertains to the original problem (avoid morphing as
much as possible :)