415161 - GTK drop-down arrows are misaligned in buttons

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Ori Avtalion (salty-horse)]

Attachment: the tab strip and location bar buttons

The native GTK drop-down arrow isn't drawn in the center of buttons. It's off to the right by a few pixels.

It's noticable in the back-forward drop-down, the tab strip, and the location bar.

Using the Ubuntu Human theme, the tab strip one has 10 pixels on the left side and 7 on the right.
I'm not sure about the location bar since it's 5 on the left side and 5 on the right. Centering cannot be achieved with a symmetric arrow icon. (Maybe that's a different bug).

Comment 1

[Ori Avtalion (salty-horse)]

Filed bug 415163 about the location bar button mentioned above.

Comment 2

[Teune van Steeg]

Attachment: patch

Remove the margins set by the not displayed label and image in the toolbar buttons where there is only an arrow: the back-forward-dropmarker and the tabs-alltabs-button toolbar buttons.

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 302731 [details] [diff] [review]
patch

>Index: browser/themes/gnomestripe/browser/browser.css
>+#back-forward-dropmarker > .toolbarbutton-image,
>+#back-forward-dropmarker > .toolbarbutton-text {
>+  margin: 0px;
>+}
s/image/icon/ and both of these are already display: none, so this isn't necessary.

r=me sans the above change - sorry for the delay!

Comment 4

[Teune van Steeg]

Attachment: patch v2

Addressing review comment.

Comment 5

[Damon Sicore (:damons)]

Comment on attachment 305021 [details] [diff] [review]
patch v2

a1.9+=damons

Comment 6

[Reed Loden [:reed]]

Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v  <--  browser.css
new revision: 1.184; previous revision: 1.183
done

Comment 7

[u294409]

The arrow is still little bit moved to the right side of button.