415170 - On Mac OS X, any comment is omitted by the Crash Reporter

Status: VERIFIED FIXED

(Toolkit :: Crash Reporting, defect, P1)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I've filed several crashes with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3pre) Gecko/2008012904 Minefield/3.0b3pre and added several comments, yet none of the reports on crash-stats show any comments :(

0d5fa930-cf7d-11dc-8af2-001a4bd43ed6
4dac41ee-cfbe-11dc-8dc1-001a4bd43ef6
12ceae59-d055-11dc-aa09-001a4bd43ed6

I've checked with a fresh profile as well.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Bleh, forgot the bp- for linkification :(

bp-0d5fa930-cf7d-11dc-8af2-001a4bd43ed6
bp-4dac41ee-cfbe-11dc-8dc1-001a4bd43ef6
bp-12ceae59-d055-11dc-aa09-001a4bd43ed6

Comment 2

[Mike Schroepfer]

Morgamic/Ted is this client side or server side?

Comment 3

[(not currently active) Ted Mielczarek]

Client side, morgamic tested Win32.  I'm investigating now.

Comment 4

[(not currently active) Ted Mielczarek]

Ok, we're using the wrong notification for the textarea, textDidEndEditing vs. textDidChange.  textDidEndEditing only fires when the text area loses focus.  If you don't tab out (and you can't tab out unless you have enabled full keyboard access or checked the "email me" box), the text never gets stored.

Easy patch, if hotel wifi will let me CVS.  :-/

Comment 5

[(not currently active) Ted Mielczarek]

Attachment: use textDidEndEditing instead

Use the right notification.

Comment 6

[Nick Kreeger]

Comment on attachment 300820 [details] [diff] [review]
use textDidEndEditing instead

r=me

Comment 7

[Mike Schroepfer]

Comment on attachment 300820 [details] [diff] [review]
use textDidEndEditing instead

a+ schrep

Comment 8

[Reed Loden [:reed]]

Checking in toolkit/crashreporter/client/crashreporter_osx.h;
/cvsroot/mozilla/toolkit/crashreporter/client/crashreporter_osx.h,v  <--  crashreporter_osx.h
new revision: 1.8; previous revision: 1.7
done
Checking in toolkit/crashreporter/client/crashreporter_osx.mm;
/cvsroot/mozilla/toolkit/crashreporter/client/crashreporter_osx.mm,v  <--  crashreporter_osx.mm
new revision: 1.18; previous revision: 1.17
done

Comment 9

[Marcia Knous [:marcia]]

verified fixed using  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3pre) Gecko/2008020104 Minefield/3.0b3pre. http://crash-stats.mozilla.com/report/index/0889f5c2-d122-11dc-a145-001a4bd43ed6 shows the comments I entered.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I also successfully submitted a report using multiple scripts and had it display correctly :-)

bp-e3c0265e-d127-11dc-9cc6-001a4bd46e84