Closed
Bug 415202
Opened 17 years ago
Closed 17 years ago
applicationManager.js unnecessarily redefines TYPE_MAYBE_FEED
Categories
(Firefox :: Settings UI, defect, P1)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
Firefox 3 beta3
People
(Reporter: myk, Assigned: myk)
Details
Attachments
(1 file)
|
606 bytes,
patch
|
beltzner
:
review+
beltzner
:
approval1.9b3+
|
Details | Diff | Splinter Review |
applicationManager.js defines TYPE_MAYBE_FEED, but that constant is already defined by applications.js, so the application manager throws an exception when opened. In todays nightly it throws the exception on Windows and Linux; Mac is spared. But with today's checkin for bug 414931, which simplifies definition of that constant, it'll throw on all three platforms.
The fix is simple: just remove that redefinition from applicationManager.js. Requesting blocking, as this breaks new functionality in Firefox 3. Here's a patch that fixes the problem.
Flags: blocking-firefox3?
|
Assignee | |
Comment 1•17 years ago
|
||
Here's the actual attachment.
Attachment #300813 -
Flags: review?(mano)
|
||
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P1
|
|
||
Comment 2•17 years ago
|
||
Comment on attachment 300813 [details] [diff] [review]
patch v1: fixes problem
r+a=beltzner
Attachment #300813 -
Flags: review?(mano)
Attachment #300813 -
Flags: review+
Attachment #300813 -
Flags: approval1.9b3+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Checking in browser/components/preferences/applicationManager.js;
/cvsroot/mozilla/browser/components/preferences/applicationManager.js,v <-- applicationManager.js
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•