Closed
Bug 41521
Opened 26 years ago
Closed 24 years ago
{ib} .style changes do not properly apply across block-in-inlines
Categories
(Core :: Layout, defect, P3)
Core
Layout
Tracking
()
RESOLVED
WORKSFORME
Future
People
(Reporter: waterson, Assigned: waterson)
References
Details
(Keywords: helpwanted)
Attachments
(3 files, 1 obsolete file)
|
289 bytes,
text/html
|
Details | |
|
1.08 KB,
text/html
|
Details | |
|
2.22 KB,
patch
|
Details | Diff | Splinter Review |
See attached test case.
Expected: bold style applies to all elements
Actual: bold only applies to first inline span
| Assignee | ||
Comment 1•26 years ago
|
||
| Assignee | ||
Updated•26 years ago
|
| Assignee | ||
Comment 2•26 years ago
|
||
| Assignee | ||
Comment 3•26 years ago
|
||
| Assignee | ||
Comment 4•26 years ago
|
||
Er, the inline block *doesn't* pick up the relative positioning. The idea here
is to force a reframe on special frames that get style changes applied to them.
Yeah, it's heavy handed. Correctness first, optimization later. ;-)
| Assignee | ||
Updated•26 years ago
|
Whiteboard: FIX IN HAND
r=buster, looks good. can't run this because I couldn't successfully merge
patch from 35935, but it makes sense and the code looks fine.
| Assignee | ||
Comment 6•26 years ago
|
||
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Updated•26 years ago
|
Status: RESOLVED → VERIFIED
Comment 7•26 years ago
|
||
Fixed in the July 14th builds.
| Assignee | ||
Comment 8•25 years ago
|
||
Looks like I broke the simple test case (attachment 9610 [details]), probably with the
changes for bug 90205.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Whiteboard: FIX IN HAND
Target Milestone: M17 → mozilla0.9.4
| Assignee | ||
Updated•25 years ago
|
Status: REOPENED → ASSIGNED
| Assignee | ||
Updated•25 years ago
|
Target Milestone: mozilla0.9.4 → mozilla0.9.5
| Assignee | ||
Updated•25 years ago
|
Target Milestone: mozilla0.9.5 → mozilla0.9.6
| Assignee | ||
Updated•24 years ago
|
Target Milestone: mozilla0.9.6 → mozilla0.9.7
| Assignee | ||
Updated•24 years ago
|
Target Milestone: mozilla0.9.7 → mozilla0.9.8
| Assignee | ||
Comment 9•24 years ago
|
||
This is a partial fix. We're still not properly re-resolving the style context
on the anonymous block, but I don't know why. Deep magic in there.
| Assignee | ||
Updated•24 years ago
|
| Assignee | ||
Comment 10•24 years ago
|
||
Pushing this out to FUTURE, as it's not likely to be that big of a deal. There's
a partial fix in attachment 63448 [details] [diff] [review]; maybe somebody who understands style
resolution can help me finish it! (Hint, hint!)
I think this is actually the same as bug 98783.
Updated•24 years ago
|
Attachment #9617 -
Attachment is obsolete: true
Comment 12•24 years ago
|
||
The test cases attached work fine now; is it fixed? See also bug 148922.
It could also have been a duplicate of bug 129350.
Comment 14•24 years ago
|
||
marking worksforme then.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago → 24 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•