Closed Bug 41521 Opened 24 years ago Closed 22 years ago

{ib} .style changes do not properly apply across block-in-inlines

Categories

(Core :: Layout, defect, P3)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME
Milestone:
Future

People

(Reporter: waterson, Assigned: waterson)

References

Details

(Keywords: helpwanted)

Attachments

(3 files, 1 obsolete file)

test case
289 bytes, text/html
Details
another test case; js animation
1.08 KB, text/html
Details
partial fix
2.22 KB, patch
Details | Diff | Splinter Review 
See attached test case.

Expected: bold style applies to all elements
Actual: bold only applies to first inline span
Attached file test case — 

    
  
Blocks: 40246
Status: NEW → ASSIGNED
Target Milestone: --- → M17

    
    

    
  


  

    
    

    
  
Er, the inline block *doesn't* pick up the relative positioning. The idea here
is to force a reframe on special frames that get style changes applied to them.
Yeah, it's heavy handed. Correctness first, optimization later. ;-)

    
  
Whiteboard: FIX IN HAND

    
    

    
  
r=buster, looks good.  can't run this because I couldn't successfully merge 
patch from 35935, but it makes sense and the code looks fine.  

    
    

    
  
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED

    
  
Status: RESOLVED → VERIFIED

    
    

    
  
Fixed in the July 14th builds.


    
    

    
  
Looks like I broke the simple test case (attachment 9610 [details]), probably with the
changes for bug 90205.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Whiteboard: FIX IN HAND
Target Milestone: M17 → mozilla0.9.4

    
  
Status: REOPENED → ASSIGNED

    
  
Target Milestone: mozilla0.9.4 → mozilla0.9.5

    
  
Target Milestone: mozilla0.9.5 → mozilla0.9.6

    
  
Target Milestone: mozilla0.9.6 → mozilla0.9.7

    
  
Target Milestone: mozilla0.9.7 → mozilla0.9.8

    
    

    
  

      
      
      
      

        Attached patch
          
          
        partial fix
        — 
          — Splinter Review
      

    


  
This is a partial fix. We're still not properly re-resolving the style context
on the anonymous block, but I don't know why. Deep magic in there.

    
  
Depends on: 90205
Keywords: helpwanted, 
          
            patch
Target Milestone: mozilla0.9.8 → Future

    
    

    
  
Pushing this out to FUTURE, as it's not likely to be that big of a deal. There's
a partial fix in attachment 63448 [details] [diff] [review]; maybe somebody who understands style
resolution can help me finish it! (Hint, hint!)

    
    

    
  
I think this is actually the same as bug 98783.

        Attachment #9617 -
        Attachment is obsolete: true

    
    

    
  
The test cases attached work fine now; is it fixed? See also bug 148922.

    
    

    
  
It could also have been a duplicate of bug 129350.

    
    

    
  
marking worksforme then.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 22 years ago
Resolution: --- → WORKSFORME

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: