Closed
Bug 415283
Opened 18 years ago
Closed 18 years ago
Button focus does not respect relief setting
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta4
People
(Reporter: ispence, Assigned: ispence)
Details
Attachments
(1 file)
|
1.50 KB,
patch
|
roc
:
review+
roc
:
superreview+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
We currently paint buttons with the correct relief since we pass that option to the paint function. However, since paint_focus does not have an argument for that, we must set button->relief correctly.
Attachment #300940 -
Flags: superreview?(roc)
Attachment #300940 -
Flags: review?(roc)
|
Assignee | |
Updated•18 years ago
|
Assignee: nobody → ispence
|
||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Summary: Button focus does not respect reflief setting → Button focus does not respect relief setting
Attachment #300940 -
Flags: superreview?(roc)
Attachment #300940 -
Flags: superreview+
Attachment #300940 -
Flags: review?(roc)
Attachment #300940 -
Flags: review+
|
|
||
Updated•18 years ago
|
Attachment #300940 -
Flags: approval1.9?
|
||
Comment 1•18 years ago
|
||
Comment on attachment 300940 [details] [diff] [review]
Sets the relief of the button so the focus is correct
a1.9+=damons
Attachment #300940 -
Flags: approval1.9? → approval1.9+
|
|
||
Updated•18 years ago
|
Keywords: checkin-needed
|
|
||
Comment 2•18 years ago
|
||
Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v <-- gtk2drawing.c
new revision: 1.74; previous revision: 1.73
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4
You need to log in
before you can comment on or make changes to this bug.
Description
•