Disabled spin buttons in Connection Settings look quite non-native on GTK+ platforms

VERIFIED FIXED in mozilla1.9beta4

Status

()

Toolkit
XUL Widgets
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: Andrés Delfino, Assigned: Teune van Steeg)

Tracking

Trunk
mozilla1.9beta4
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008020203 Minefield/3.0b3pre FireShot/0.32
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008020203 Minefield/3.0b3pre FireShot/0.32

See the differences in these two screenshots.

gedit 2.20.1.

Reproducible: Always
(Reporter)

Updated

10 years ago
Version: unspecified → Trunk
(Reporter)

Comment 1

10 years ago
Created attachment 301020 [details]
Minefield screenshot.
(Reporter)

Comment 2

10 years ago
Created attachment 301021 [details]
gedit screenshot

Comment 3

10 years ago
Is this an incomplete fix of bug 399545?
(Assignee)

Comment 4

10 years ago
(In reply to comment #3)
> Is this an incomplete fix of bug 399545?
> 
No actually it was (not intentionally) fixed by bug 399545, but regressed by bug 409388.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Updated

10 years ago
Assignee: nobody → twanno
Status: ASSIGNED → NEW
Component: General → XUL Widgets
Product: Firefox → Toolkit
(Assignee)

Comment 5

10 years ago
Created attachment 301621 [details] [diff] [review]
patch

Make the text field inherit the disabled attribute. 
To make sure the html input does not inherit the background-color from the hbox (white even when disabled), the color style rules have to be removed.
Attachment #301621 - Flags: review?(enndeakin)

Updated

10 years ago
Attachment #301621 - Flags: review?(enndeakin) → review+
(Assignee)

Comment 6

10 years ago
Comment on attachment 301621 [details] [diff] [review]
patch

Makes disabled numberboxes look completely disabled on Linux.
Attachment #301621 - Flags: approval1.9?

Updated

10 years ago
Attachment #301621 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
QA Contact: general → xul.widgets
Checking in toolkit/themes/gnomestripe/global/numberbox.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/numberbox.css,v  <--  numberbox.css
new revision: 1.4; previous revision: 1.3
done
Checking in toolkit/content/widgets/numberbox.xml;
/cvsroot/mozilla/toolkit/content/widgets/numberbox.xml,v  <--  numberbox.xml
new revision: 1.7; previous revision: 1.6
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4
(Reporter)

Updated

10 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.