415357 - Disabled spin buttons in Connection Settings look quite non-native on GTK+ platforms

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Andrés Delfino]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008020203 Minefield/3.0b3pre FireShot/0.32
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008020203 Minefield/3.0b3pre FireShot/0.32

See the differences in these two screenshots.

gedit 2.20.1.

Reproducible: Always

Comment 1

[Andrés Delfino]

Attachment: Minefield screenshot.

Comment 2

[Andrés Delfino]

Attachment: gedit screenshot

Comment 3

[[:Aleksej]]

Is this an incomplete fix of bug 399545?

Comment 4

[Teune van Steeg]

(In reply to comment #3)
> Is this an incomplete fix of bug 399545?
> 
No actually it was (not intentionally) fixed by bug 399545, but regressed by bug 409388.

Comment 5

[Teune van Steeg]

Attachment: patch

Make the text field inherit the disabled attribute. 
To make sure the html input does not inherit the background-color from the hbox (white even when disabled), the color style rules have to be removed.

Comment 6

[Teune van Steeg]

Comment on attachment 301621 [details] [diff] [review]
patch

Makes disabled numberboxes look completely disabled on Linux.

Comment 7

[Reed Loden [:reed]]

Checking in toolkit/themes/gnomestripe/global/numberbox.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/numberbox.css,v  <--  numberbox.css
new revision: 1.4; previous revision: 1.3
done
Checking in toolkit/content/widgets/numberbox.xml;
/cvsroot/mozilla/toolkit/content/widgets/numberbox.xml,v  <--  numberbox.xml
new revision: 1.7; previous revision: 1.6
done