415362 - [10.3][10.4] Crash opening preferences

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Markus Haenchen]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1.12pre) Gecko/20080118 Camino/1.6b2 (like Firefox/2.0.0.12pre)
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1.12pre) Gecko/20080118 Camino/1.6b2 (like Firefox/2.0.0.12pre)

On http://www.luminous-landscape.com, clicking on the RSS icon in the location window and selecting the second option in the pop-up, 'Feed Preferences...', causes Camino to crash.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Markus Haenchen]

Attachment: Crash log

Comment 2

[Stuart Morgan]

Does opening the Camino preferences directly and switching to General also crash? Does this crash happen when you aren't running Camino under rosetta, and/or when you remove your input managers and APE?

Comment 3

[Markus Haenchen]

Yes, it does crash when opening the preferences directly (this must be pretty recent, I think I have successfully opened the only a few weeks ago).
Yes, the crash also happens when not running under Rosetta.
Yes, the crash also happens when I disable the application enhancer (and log out and back in).

Comment 4

[Stuart Morgan]

Could you download the latest 1.6b3 nightly build, reproduce the crash with that running natively, and post that crash log? We made a change recently that improves the quality of crash reports, and it might give us more information.

Also, are there any messages logged to the console when you reproduce the crash?

Comment 5

[Markus Haenchen]

Attachment: Crash log w/ 1.6b3pre

Both Console and System.log only say that Camino crashed and that a crash log was written (crashdump[27110]).

Comment 6

[Stuart Morgan]

Hmm, I'm not seeing how that would crash. What does the following show when run in Terminal?
defaults read org.mozilla.camino "Last Selected Preference Pane"

Comment 7

[Markus Haenchen]

org.mozilla.camino.preference.privacy
(last thing I remember doing in the preferences was changing the cookie allow/deny status for a few sites)
BTW, 1.5.4 still runs fine.

Comment 8

[Stuart Morgan]

If you open prefs in 1.5.4, change to something other than Privacy, then go back to 1.6b3pre, can you open prefs (and presumably crash when trying to switch to Privacy), or does it still crash immediately on opening prefs?

Comment 9

[Markus Haenchen]

Preferences in 1.5.4 open to the General pane, switching a bit around, close with General active again (my 1.5.4 has this occasional crash on quit).
In 1.6b3pre, opening preferences still crashes Camino.
While 1.5.4 is running and after quitting it, the Terminal command keeps reading 'privacy'.

Comment 10

[Stuart Morgan]

That's odd; changing the prefs selection in Camino 1.5 and quiting should change the defaults. How about manually changing the pref (you'll need to quit any open copy of Camino before doing this):
defaults write org.mozilla.camino "Last Selected Preference Pane" org.mozilla.camino.preference.tabs

After you've tried that, please also test with a clean profile using:
http://pimpmycamino.com/parts/troubleshoot-camino

Once this is narrowed down a bit further, I'll make a build that does some logging to see if we can pinpoint where it's crashing.

Comment 11

[Markus Haenchen]

Changing the prefs selection manually works. Tested both with the default reads command and by starting Camino 1.6b3pre. Preferences can be opened in it and open in 'Tabs'. Switching to 'Privacy' crashes it. Same behaviour when using a clean profile.

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Markus, does switching to General still crash Camino, or just switching to Privacy?

One other thing to try is (temporarily) moving your ~/Library/Preferences/org.mozilla.camino.plist file aside and launching Camino.  If you don't crash when opening General (or Privacy now?) then, your existing-just-moved-aside org.mozilla.camino.plist could be involved in the crash (and we'll want to see it).

Comment 13

[Markus Haenchen]

After setting the pref selection via the Terminal to 'Tabs' I can now open the preferences without problems. But switching to 'Privacy' crashes Camino. 

I just moved the .plist file aside (and restarted Camino). Switching to 'Privacy' after that caused Camino to hang (100% CPU) instead of crashing (I had seen this once before). I had a look at the open files and sampled it via Activity Monitor (before posting it here, I'd like to clean out personal data).

Comment 14

[Markus Haenchen]

After both moving the .plist and using a clean profile (troubleshoot camino.app) I am now crash-free (w/1.6b3pre). My old .plist however still reproducibly crashes Camino when switching to the Privacy tab in the preferences. Since the .plist contains my local username, I'd be loth to post it here directly. Can I send to you by other means?

Out of ~20 crashes, two 'only' resulted in Camino hanging. Below I post the open files and the sample as mentioned before.

Comment 15

[Markus Haenchen]

Attachment: List of open files of Camino while it was hanging

Comment 16

[Markus Haenchen]

Attachment: Sample of Camino while it was hanging

Comment 17

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Stuart, any thoughts on where we go next here?

Comment 18

[Stuart Morgan]

Markus, would you be willing to email me the plist of doom? I might be able to figure out from that what's happening.

Failing that, I'll need to make a logging build when I have time, probably after b3.

Comment 19

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Markus, were you submitting Talkback reports for this?  I noticed a large number of reports mentioning crashing in Privacy with stacks all looking like TB41784319.  I'm hoping they're all you and not this problem becoming more widespread :(

Comment 20

[Markus Haenchen]

I don't think I have Talkback enabled (I don't even know how to enable it), I only use the Apple crash reporter that is present for all apps. And I did not have [a Privacy tab related] crash since about a month ago.

Comment 21

[captainnitpick]

Attachment: org.mozilla.camino.plist that crashes Camino on switch to privacy prefpane

He's not the only one encountering this. I've been reliably seeing this privacy prefpane crash. Somehow I missed trying deleting org.mozilla.camino.plist (tried all the other Camino files, but not that one).

Included is one that reliably crashes my install.

Comment 22

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We've gotten two Talkback reports of this already, TB43085966x and TB43085361x; [e-mail], are these from you?

Comment 23

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Whoops, [e-mail] wasn't cc'd, so he/she didn't see comment 22.

Comment 24

[Stuart Morgan]

With b3 out, I finally have some time to look at this. I can't repro a crash with either plist on 10.5, but I can on 10.4. I'll work on narrowing it down to see how we might be able to work around it.

Comment 25

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Ooops, I took too long writing ;)

I can also reproduce this on 10.3.9/PPC with 1.6b3 with the org.mozilla.camino.plist in comment 21.

Preferences open OK (the last selected pane is Web Features), but switching to Privacy causes the crash while Privacy is attempting to load.

I can't reproduce this on 10.5.2/Intel.  Both Markus (Intel) and captainnitpick (PPC; yay update url!) are on 10.4; I wonder if this might have been an underlying OS bug that Apple fixed in 10.5?

Comment 26

[Stuart Morgan]

Well, this is really unfortunate. What's happened is that something about the saved state of the exceptions table is (at least in these cases) apparently not compatible with a change we made; just removing "NSTableView Columns exceptions_list" from the file is enough to fix it.

The unfortunate part is that the obvious way to fix it is to change the autosave name for that table... in the nib. So the options I see given l10n are:
1) I put in a somewhat ugly one-time removal of that pref key on launch, or
2) I manually make this change to all the localized nibs once they are done (which would be *much* easier than making people re-localize the nib).

I'd be willing to do 2, but I have a feeling it would be a process nightmare for the l10n side, so I guess I'll put together code for 1 to land on the branch. For trunk, I'll do the easy fix.

Comment 27

[captainnitpick]

Both of those Talkback reports were mine.

Comment 28

[Stuart Morgan]

Attachment: trunk nib

This just changes the autosave name of the cookie exceptions table (and the cookie table as well, just to be safe).

Comment 29

[Stuart Morgan]

Attachment: branch patch

Clears all the autosaves for those tables once.

Theoretically, someone could go to 1.6, then back to 1.5, then back to 1.6 (adjusting the tables each time) and get into trouble, but I think that's unlikely enough that we can ignore it.

Comment 30

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 311737 [details]
trunk nib

rs=pink

Comment 31

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 311738 [details] [diff] [review]
branch patch

sr=pink

Comment 32

[Stuart Morgan]

Nib landed on trunk, patch landed on MOZILLA_1_8_BRANCH.