415451 - Array.lastIndexOf does not work correctly

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Ahmed Ashour]

User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; .NET CLR 2.0.50727; .NET CLR 3.0.04506.30)
Build Identifier: 

The following code should return 3 instead of 0.

[2, 5, 9, 2].lastIndexOf(2,-1)

Reproducible: Always

Steps to Reproduce:
1.
2.
3.


Expected Results:  
3

Comment 1

[Norris Boyd]

Attachment: js1_5/Regress/regress-415451.js

Proposed test case

Comment 2

[Norris Boyd]

Checking in src/org/mozilla/javascript/NativeArray.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/NativeArray.java,v  <--  Na tiveArray.java
new revision: 1.86; previous revision: 1.85
done

Checking in NativeArray.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/NativeArray.java,v  <--  NativeArray.java
new revision: 1.83.2.3; previous revision: 1.83.2.2
done

Comment 3

[Norris Boyd]

Bob, can you review the proposed regression test when you have a chance?

Comment 4

[Bob Clary [:bc] (inactive)]

Comment on attachment 301267 [details]
js1_5/Regress/regress-415451.js

r+ but put it in js1_5/extensions since Array.prototype.indexOf is not required by the standard.

Could you flip the in-litmus flag to - and the in-testsuite flag to + when you check in please?

Comment 5

[Bob Clary [:bc] (inactive)]

Actually, js1_6/Array is the better place for this.

Comment 6

[Norris Boyd]

Checking in js1_6/Array/regress-415451.js;
/cvsroot/mozilla/js/tests/js1_6/Array/regress-415451.js,v  <--  regress-415451.js
initial revision: 1.1
done

Also flipped bits.