415492 - tabs hover animation

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Description

[Dão Gottwald [:dao]]

Attachment: proposed animation as extension

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Dão Gottwald [:dao]]

Attachment: tab-hover-bkgnd.png

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 301190 [details]
proposed animation as extension

I think this will be one of those tricksy things that will be tough to get just right. I like the overall effect, but it feels just a smidgen slow to me at the moment. Can we remove one or two frames of the animation to speed it up?

Comment 4

[Dão Gottwald [:dao]]

Attachment: v2 as extension

This is more subtle with 3 instead of 5 frames, frame length is 50 ms.

Comment 5

[Dão Gottwald [:dao]]

Attachment: tab-hover-bkgnd.png v2

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 305335 [details]
v2 as extension

Yeah, this is better. We might even be able to add that fourth frame - what do you think? Right now it feels "fast" and the hover is *just* noticable.

Comment 7

[Dão Gottwald [:dao]]

Attachment: tab-hover-bkgnd.png v3

4 frames @ 50 ms

Comment 8

[Dão Gottwald [:dao]]

Attachment: patch

Comment 9

[Asaf Romano (gone)]

Why is repeat-x set in some places and not in others?

Comment 10

[Dão Gottwald [:dao]]

It's set on the base rules. E.g. we don't need to mention it in .tabbrowser-tab:hover if .tabbrowser-tab already has it.

Comment 11

[Asaf Romano (gone)]

Comment on attachment 306391 [details] [diff] [review]
patch

*ah*, ok. r=mano.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 306391 [details] [diff] [review]
patch

uir=beltzner carried over

Drivers: requesting approval for this after beta 4; small but noticable polish for tab hovering on Windows. It's these little things that make applications more human and pleasant.

Comment 13

[Dão Gottwald [:dao]]

Attachment: updated to trunk

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 306855 [details] [diff] [review]
updated to trunk

a1.9=beltzner

Comment 15

[Reed Loden [:reed]]

Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.css
new revision: 1.185; previous revision: 1.184
done
Checking in browser/themes/winstripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/winstripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.76; previous revision: 1.75
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tab-hover-bkgnd.png,v
done
Checking in browser/themes/winstripe/browser/tabbrowser/tab-hover-bkgnd.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tab-hover-bkgnd.png,v  <--  tab-hover-bkgnd.png
initial revision: 1.1
done

Comment 16

[Jochen De Smet]

Is there any way to disable this animation? I'm probably in the minority, but I find it to be very annoying and distracting.

Comment 17

[Dão Gottwald [:dao]]

(In reply to comment #16)
> Is there any way to disable this animation?

userChrome.css:

.tabbrowser-tab:hover {
  background-image: url("chrome://browser/skin/tabbrowser/tab-active-bkgnd.png") !important;
}