415530 - Error: this.mInput.removeAttribute is not a function

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Simon Bünzli]

Steps to Reproduce:
1. Go to www.google.com
2. Search for "firefox"
3. Now enter "fyi" into Google's search field (so that at first "firefox" is suggested and then there are no more suggestions available)

Actual result:
When the autocomplete popup is hidden (as there are no more suggestions available), the following error is thrown:

Error: this.mInput.removeAttribute is not a function
Source File: chrome://global/content/bindings/autocomplete.xml
Line: 813

Comment 1

[Neil Deakin]

Probably a regression from bug 414845

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Indeed, the popup code can't assume that mInput is anything other than an nsIAutocompleteInput. In the content autocomplete case, for example, it's a nsFormFillController instead of an actual element.

Comment 3

[Dão Gottwald [:dao]]

FrnchFrgg, any idea how to fix this? Maybe try/catch would be acceptable in this case? If nothing else, backing out bug 414845 would do.

Comment 4

[Julien "_FrnchFrgg_" RIVAUD]

gavin said on irc that try/catch would be a crude hack. Perhaps adding a "if (popupishistorypopup)" at the right place, or add a specific event listener for the urlbar (or for autocomplete[history=true]) ?

Comment 5

[Reed Loden [:reed]]

Backed out bug 414845, so this should be fixed now.