Closed
Bug 415547
Opened 17 years ago
Closed 17 years ago
ActionMonkey: JS_MaybeGC does not set gcPendingContext
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jorendorff, Assigned: jorendorff)
References
Details
Attachments
(1 file)
|
2.34 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
JS_MaybeGC() does not set up the gcPendingContext the way js_GC() does. This should cause a crash when MMgc callbacks start firing (gcPendingContext is null).
For some reason this code passes the tests fine, though, with JS_MaybeGC being called regularly in the branch callback. So, possibly INVALID, but some detective work is appropriate.
|
Assignee | |
Comment 1•17 years ago
|
||
It doesn't crash because GC::MaybeGC() never triggers GC. Need to revisit that heuristic -- but let's fix this anyway.
Blocks: 411563
|
|
Assignee | |
Comment 2•17 years ago
|
||
Assignee: general → jorendorff
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•17 years ago
|
Attachment #308052 -
Flags: review?(benjamin)
|
||
Updated•17 years ago
|
Attachment #308052 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
pushed changeset 477e5f531cb9 to actionmonkey
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•