415566 - Use new NSPR atomic macros - general

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect)

Description

[Steve Snyder]

Attachment: Replace PR_Atomic[operation] function calls with equivelent macros

Use the recently-added NSPR atomic Increment/Decrement/Set/Add macros rather
than function calls in existing code.  The goal is to improve general
performance by moving those atomic operations to inline code.

The inline code is much faster than the function calls at the cost of
increasing the code size by about 8 bytes per use.

For platforms that do not support the use of inline atomic operations, the
original function calls are used, making this patch a no-op.

Comment 1

[Steve Snyder]

Marked as dependant on bug 415563 because that patch adds MSVC-compatible casting of parameters to atomic intrinsic functions.

Comment 2

[Steve Snyder]

Attachment: A less general general patch

Original patch was a little too general.  Removed Python and JavaScript subsystems.

Comment 3

[Steve Snyder]

Attachment: Reformatted, with CVS

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:overholt, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Andrew McCreight [:mccr8]]

Probably at this point we don't want to use NSPR if possible...