Closed Bug 415759 Opened 12 years ago Closed 12 years ago
Joey, what's the rationale for this blocking 0.8? Does this cause any bugs? If yes, which bugs?
I agree this blocks.
I don't see this errors using Sunbird 0.8pre (2008020507) or Sunbird 0.6a1 (2008020418) on Windows XP. The bug is filed for Trunk - does this also happens using a mozilla1.8 branch build? Can you narrow down the regression range?
(In reply to comment #4) Sorry, I didn't bother with the defaults for version, etc. This happens with the latest nightly build on Mac. Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:22.214.171.124pre) Gecko/20080204 Calendar/0.8pre The minimonth error has existed since prior to 0.7, I don't have a range on the unifinderTree error.
Version: Trunk → Mozilla 1.8 Branch
Needs investigation. And no, we don't want to ship with js errors, at least not with code errors.
Flags: blocking-calendar0.8? → blocking-calendar0.8+
For now, my guess is that at least the minimonth error is related to the mac hidden window. That window also includes the js script. But there is of course no minimonth in that window, so the code fails. I indeed to not see any errors on my linux build. (but that's severly hacked, so i don't want to draw too much conclusions from it) I don't have a mac right now to test if the function is indeed called twice.
I indeed see the onload function called twice. This confirms that one is the hidden window. In that window, there are no minimonths etc to attach any listeners to. So the checks I added in the patch are safe.
Attachment #302120 - Flags: review?(philipp)
Comment on attachment 302120 [details] [diff] [review] patch Looks good, thanks for taking care! r=philipp
Attachment #302120 - Flags: review?(philipp) → review+
patch checked in
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Version: Mozilla 1.8 Branch → unspecified
You need to log in before you can comment on or make changes to this bug.