415786 - escrow warning dialog is broken

Status: VERIFIED FIXED

(Core :: Security: PSM, defect, P2)

Description

[Kai Engert (:KaiE:)]

Try to open chrome://pippki/content/escrowWarn.xul
(This dialog will be shown during some crypto operations, such as certificate enrollment.)

The dialog fails to open with an error message, because one of the strings is no longer available.

The string 
  <!ENTITY examineCert.label "View Certificate">
got accidentially removed from pippki.dtd as part of the changes for bug 327181.

Comment 1

[Kai Engert (:KaiE:)]

Attachment: Patch v1

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 301513 [details] [diff] [review]
Patch v1

This doesn't need ui-review.

Comment 3

[Axel Hecht [:Pike]]

Bug 327181 removed the following comment, too:

<!-- Strings for the MismatchDomain dialog  -->

Not sure if that comment still applies, or should be replaced with something more reasonable in the new patched world.

Comment 4

[Kai Engert (:KaiE:)]

(In reply to comment #3)
> Bug 327181 removed the following comment, too:
> <!-- Strings for the MismatchDomain dialog  -->

That dialog got completely removed, and my intention was to remove the associated strings.

I had missed the cert examineCert.label was still used somewhere else.
But on the other hand I didn't remove the accesskey, which makes me believe I simply deleted that line without thinking enough...

If you think it helps, I could add a comment that lists the name of the dialog where this string is being used (escrowWarn).

Comment 5

[Axel Hecht [:Pike]]

I think we should move both entities down to the escrow entities, then.

I guess that'd be more useful than adding a comment in this case.

Comment 6

[Kai Engert (:KaiE:)]

Attachment: Patch v2

This addresses Axel's proposal and moves both strings further down.

Comment 7

[Robert Relyea]

Comment on attachment 301523 [details] [diff] [review]
Patch v2

r+ yes, let's get this fixed.

bob

Comment 8

[bill]

Attachment: Escrow certificate dialog parsing error

Comment 9

[Reed Loden [:reed]]

Comment on attachment 301523 [details] [diff] [review]
Patch v2

Need explicit approval for this since it's late-l10n.

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 301523 [details] [diff] [review]
Patch v2

This patch has a "yes, please approve" from me.

Comment 11

[Kai Engert (:KaiE:)]

fixed

Checking in en-US/chrome/pippki/pippki.dtd;
/cvsroot/mozilla/security/manager/locales/en-US/chrome/pippki/pippki.dtd,v  <--  pippki.dtd
new revision: 1.5; previous revision: 1.4
done

Comment 12

[Kai Engert (:KaiE:)]

FYI, the check in was too late for today's nightly builds, but builds dated on or after 2008-02-08 should be fixed.

Comment 13

[Reed Loden [:reed]]

(In reply to comment #12)
> FYI, the check in was too late for today's nightly builds, but builds dated on
> or after 2008-02-08 should be fixed.

Actually, we respun nightlies, so it did make it in today. :)

Comment 14

[Carsten Book [:Tomcat]]

verified fixed using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008050804 Minefield/3.0pre and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050614 Minefield/3.0pre and the steps to reproduce from kai.