415789 - showing an embedded Browser without giving it content does not draw a blank background

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P2)

Description

[Grant Gayed]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041115
Build Identifier: Mozilla XULRunner 1.9b3pre - 2008020416

I see this on Linux and Windows, but not on OSX.

Our app embeds gecko for showing html content (it does not use gtkmozembed, but gtkmozembed can be used to show the problem).  When the embedded gecko is initially shown it does not have any content, until a client sets a url on it.  During this interval it should just appear as a blank control.  Prior to 1.9 it did this, but as of 1.9 it no longer draws its background.  This looks "broken" for any app written before 1.9 that embeds a gecko browser without initial content.


Reproducible: Always

Steps to Reproduce:
1. build xulrunner with --enable-tests
2. run the built TestGtkEmbed app
3. The embedded browser does not draw its background.  If you move another shell on top of it and then bring the TestGtkEmbed app back to the top you'll see the other shell's content left over on it.

Actual Results:  
I'll attach a screenshot in the next comment.

Comment 1

[Grant Gayed]

Attachment: screenshot

Comment 2

[Doug Turner (:dougt)]

I see the same thing.  Loading about:blank seams to make it look "right".  Grant, do you see the same behavior?

Comment 3

[Grant Gayed]

Yes, loading about:blank makes it look like it did pre-1.9.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This fixes it. GTK2 nsWindow::OnExposeEvent treates nsEventStatus_eIgnore result as cancelling the paint operation ... so nsWebBrowser needs to return something else to indicate it did paint.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 312826 [details] [diff] [review]
fix

Ah, my good friend nsEventStatus...

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 7

[Grant Gayed]

Reopening.  In the April 30th XULRunner nightly build this is fixed on Linux but not on Windows (2000).

Note that I don't compile XULRunner from source on Windows so I don't have TestGtkEmbed there.  The test case that I still see this problem in is embedding XULRunner in the SWT Browser.

Comment 8

[Grant Gayed]

To clarify comment 7, I would suspect that TestGtkEmbed still fails on Windows, I just have not seen it myself.

Comment 9

[Grant Gayed]

Sorry, that's obviously not true since TestGtkEmbed isn't for Windows.  Does Windows have a similar demo app that could show this easily?  Or some other means?  If needed I can give steps for replicating this in the swt Browser, though I suspect you would prefer a lower-level case if possible.

Comment 10

[Benjamin Smedberg]

This bug is about TestGtkEmbed. You are welcome to file a new/separate bug about the SWT browser issue.