Closed Bug 415837 Opened 16 years ago Closed 16 years ago

search plug in review for Fx3 Swedish (sv-SE)

Categories

(Mozilla Localizations :: sv-SE / Swedish, defect)

Product:
Mozilla Localizations
Component:
sv-SE / Swedish
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Future

People

(Reporter: mic, Assigned: u60234)

References

Details

Attachments

(1 file)

patch v1
10.61 KB, patch
Gavin
: review+
Details | Diff | Splinter Review 
new proposed list of search engines to replace current en-US defaults as suggested by Hasse and Swedish community:

Google
Yahoo
Allaannonser
Creative Commons
Prisjakt
Tyda.se
Wikipedia

Shopping engines: 
Allaannonser is a meta search engine for classified ads and auctions that has a pretty clean interface
Prisjakt price comparison and consumer guide site

Specific engines:
Tyda.se free dictionary and translation service

seeking permission and appropriate search plug-ins/search parameters
from Tyda.se

----- Original Message -----
From: "Tommy Svensson (TYDA)" <tommy@tyda.se>
To: "Michal Berman" <mic@mozilla.com>
Cc: hasse@jasajudeju.se
Sent: Tuesday, February 5, 2008 6:57:22 PM (GMT-0500) America/New_York
Subject: RE: your service in Firefox Swedish

Hi!

You're indeed very welcome to include our dictionary service in the next
version of FF.

I believe Hasse already has a plugin available for you/us.

/T

# Tommy Svensson, CEO
# Tyda Sverige AB
Whiteboard: needs-mic
from allaannonser, permission:


----- Original Message -----
From: "Andereas Friis" <andereas@allaannonser.se>
To: "Michal Berman" <mic@mozilla.com>
Sent: Wednesday, February 6, 2008 4:27:12 AM (GMT-0500) America/New_York
Subject: SV: including your service in Firefox

Hello,

You have our permission to include www.allaannonser.se as a default plug-in to your new release of Firefox.

Best Regards,
Andereas Friis
www.AllaAnnonser.se
for prisjakt:

----- Original Message -----
From: "Franz Hänel" <franz@prisjakt.nu>
To: "Michal Berman" <mic@mozilla.com>
Sent: Tuesday, February 5, 2008 7:08:22 PM (GMT-0500) America/New_York
Subject: Re: your service in Firefox Swedish

Hi Mic,

I give you our permission to include our service in your default set of
search plug-ins.

I'll send you the plug-in in a couple of days if that's ok?

Kind regards,
Franz Hänel
Prisjakt Sverige AB 
for Prisjakt, instruction for their plug in:

We have a plugin here:
http://www.prisjakt.nu/plugins/opensearch/opensearch.xml

It can be installed using this page:
http://www.prisjakt.nu/plugins/opensearch/
Whiteboard: needs-mic → needs-patch
Attached patch patch v1 — — Splinter Review 
I changed the root name and namespace in the plugin that Prisjakt provided to match the Mozilla convention. For AllaAnnonser and Tyda, I have received their OK on the URL:s and parameters.

Note: I have included a Swedish version of the Creative Commons plugin where the only change I've made is that " (en)" is appended to the shortname. We would like to have such an indication since the search engine is English only.
Attachment #302621 - Flags: review?(l10n)
Whiteboard: needs-patch → needs-gavin
Is Gavin supposed to review this patch?
Status: NEW → ASSIGNED
yep, on his radar with whiteboard: needs-gavin :)
Attachment #302621 - Flags: review?(l10n) → review?(gavin.sharp)
Comment on attachment 302621 [details] [diff] [review]
patch v1

>Index: creativecommons-sv-SE.xml

>+<ShortName>Creative Commons (en)</ShortName>

How important is this change to you? It would be much easier from a maintenance point of view to just use the en-US plugin directly.

>Index: tyda-sv-SE.xml

>+<InputEncoding>ISO-8859-1</InputEncoding>

Are you sure this is correct? The tyda.se page seems to use UTF-8.

This looks good with those addressed, sorry for the delay!
Attachment #302621 - Flags: review?(gavin.sharp) → review+
Whiteboard: needs-gavin
Oh, and it would be nice if the prisjakt plugin used <Param> elements rather than just putting the parameters in the template, but that's not critical.
(In reply to comment #8)
> (From update of attachment 302621 [details] [diff] [review])
> >Index: creativecommons-sv-SE.xml
> 
> >+<ShortName>Creative Commons (en)</ShortName>
> 
> How important is this change to you? It would be much easier from a maintenance
> point of view to just use the en-US plugin directly.

True, there is a cost here. But we believe that having " en" appended would still be nice.

Mic, do you think this is a good idea?
 
> >Index: tyda-sv-SE.xml
> 
> >+<InputEncoding>ISO-8859-1</InputEncoding>
> 
> Are you sure this is correct? The tyda.se page seems to use UTF-8.

Searches on Tyda with chars relevant to Swedish, like åäöé, seems to work with both ISO-8859-1 and UTF-8. But since the site uses UTF-8 we should use that too.

Checked in the patch with that change, and with separate <Param> elements for Prisjakt. I will wait for Mic's advice on the Creative Commons plugin before I proceed with that.

Checking in list.txt;
/l10n/l10n/sv-SE/browser/searchplugins/list.txt,v  <--  list.txt
new revision: 1.6; previous revision: 1.5
done
RCS file: /l10n/l10n/sv-SE/browser/searchplugins/allaannonser-sv-SE.xml,v
done
Checking in allaannonser-sv-SE.xml;
/l10n/l10n/sv-SE/browser/searchplugins/allaannonser-sv-SE.xml,v  <--  allaannonser-sv-SE.xml
initial revision: 1.1
done
RCS file: /l10n/l10n/sv-SE/browser/searchplugins/prisjakt-sv-SE.xml,v
done
Checking in prisjakt-sv-SE.xml;
/l10n/l10n/sv-SE/browser/searchplugins/prisjakt-sv-SE.xml,v  <--  prisjakt-sv-SE.xml
initial revision: 1.1
done
RCS file: /l10n/l10n/sv-SE/browser/searchplugins/tyda-sv-SE.xml,v
done
Checking in tyda-sv-SE.xml;
/l10n/l10n/sv-SE/browser/searchplugins/tyda-sv-SE.xml,v  <--  tyda-sv-SE.xml
initial revision: 1.1
done
Removing amazon-en-GB.xml;
/l10n/l10n/sv-SE/browser/searchplugins/amazon-en-GB.xml,v  <--  amazon-en-GB.xml
new revision: delete; previous revision: 1.1
done
Removing eBay-en-GB.xml;
/l10n/l10n/sv-SE/browser/searchplugins/eBay-en-GB.xml,v  <--  eBay-en-GB.xml
new revision: delete; previous revision: 1.1
done


Mic, can you advise on what we should do with the Creative Commons plugin? We would like to have our own plugin with the short name "Creative Commons (en)" so users are warned that the search service is English only. But Gavin says in comment #8 that he would prefer if we use the en-US plugin as it is.
Adding a needs-mic, for reference, I'd prefer just one creative-commons plugin, too.
Whiteboard: needs-mic
Having a en-US plugin together with sv-SE ones, without mention that it's only in english could be a bit confusing, I think. What are the maintenance costs?
That any changes to the creative-commons plugin needs to be replicated into an sv-SE-specific bug, and the person that changed creative-commons in en-US needs to actually know about that.

Looking at the ShortNames, I don't think this is really an issue. Most plugins are obviously Swedish, only yahoo and creative commons have English names, so one could read this either way, yahoo should say it's swedish, or creative commons should say it's English, or both. I really think that it's adding way more noise than necessary.

As the creative commons site isn't translated (as yahoo is), there isn't a chance for ambiguity there, too.
(In reply to comment #14)
> That any changes to the creative-commons plugin needs to be replicated into an
> sv-SE-specific bug, and the person that changed creative-commons in en-US needs
> to actually know about that.
> 
> Looking at the ShortNames, I don't think this is really an issue. Most plugins
> are obviously Swedish, only yahoo and creative commons have English names, so
> one could read this either way, yahoo should say it's swedish, or creative
> commons should say it's English, or both. I really think that it's adding way
> more noise than necessary.

(Note: I'm not trying to make this a huge issue, I just like to clarify)

It's not about the names, yahoo is well known in Sweden and I don't think users will be surprised that their site is in Swedish. So, yahoo doesn't need to say it's swedish. On the other hand, Creative Commons might be expected to be in Swedish since all the others are.

Stefan, understand your point but we haven't done this anywhere. the only place we indicate is wikipedia to my knowledge so i think adding that is creating a precedent that is kind of a bigger issue. if you feel strongly i will review with ui/ue team
> if you feel strongly i will review
> with ui/ue team

If it's just me, I don't think it's worth the extra work/issues. So, Hasse and Mikael - what's your opinion here?


I do appreciate the problem a Swedish version of the plugin would cause, so I'm OK with using the en-US plugin.

I re-added that plugin to our list.txt.

Checking in list.txt;
/l10n/l10n/sv-SE/browser/searchplugins/list.txt,v  <--  list.txt
new revision: 1.7; previous revision: 1.6
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: needs-mic
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: