Error console should respect line breaks in error messages

RESOLVED FIXED in mozilla1.9beta4

Status

Toolkit Graveyard
Error Console
RESOLVED FIXED
9 years ago
10 months ago

People

(Reporter: Wladimir Palant, Assigned: Wladimir Palant)

Tracking

Trunk
mozilla1.9beta4

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 301650 [details] [diff] [review]
Proposed patch

Right now, you have to do |consoleService.logStringMessage()| to show a multi-line message in the console. If you want to give more information in a warning message that you add via |consoleService.logMessage()| - no chance, line breaks will be ignored and the entire text will be displayed on one line. That's because of this rule in console.css:

.console-msg-text {
  white-space: -moz-pre-wrap;
}

It applies to informational messages only but not to errors or warnings. I don't see any good reason for that.
Attachment #301650 - Flags: review?(gavin.sharp)
Comment on attachment 301650 [details] [diff] [review]
Proposed patch

Sorry for the delay.
Attachment #301650 - Flags: review?(gavin.sharp) → review+
Assignee: nobody → trev.moz
Attachment #301650 - Flags: approval1.9?
Comment on attachment 301650 [details] [diff] [review]
Proposed patch

a1.9+=damons
Attachment #301650 - Flags: approval1.9? → approval1.9+
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
Checking in toolkit/components/console/content/console.css;
/cvsroot/mozilla/toolkit/components/console/content/console.css,v  <--  console.css
new revision: 1.6; previous revision: 1.5
done
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta4
Product: Firefox → Toolkit
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.