415915 - Drag / Drop in the Bookmarks Menu is broken

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[hhh]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008020523 Minefield/3.0b4pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008020523 Minefield/3.0b4pre

In the Bookmarks Menu, if I drag and drop a bookmark from the middle of the list to the top, it ends up at the bottom. Once there it can't be moved itself, only replaced by another moved bookmark.

Reproducible: Always

Steps to Reproduce:
1.Drag your last bookmark in the Bookmarks Menu dropdown to any other position in the list.
2.
3.
Actual Results:  
Bookmark is still last on the list.

Expected Results:  
Bookmark should move.

I also tested build [ Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007092305 Minefield/3.0a9pre ] and drag and drop wasn't fully accurate even then. I'll try to narrow down a regression window today.

Comment 1

[Marco Bonardo [:mak]]

for me this really happens for all bookmarks, not only the last, they go to the bottom. The funny thing is that draggin an item from a submenu puts at bottom of main bookmarks menu

Comment 2

[Jim Jeffery not reading bug-mail 1/2/11]

I can't find it now, still looking, but I thought I saw a patch in the last few days that forced changes to fall to the bottom - ?

Comment 3

[Marco Bonardo [:mak]]

yes it was my patch (bug 415521), for sorted views. diabling that code does not change anything

Comment 4

[Marco Bonardo [:mak]]

from first analisys something between 29/01 and 30/01 has regressed the bookmarks menu, before it was hilighting the correct position (white hilight), now it always put at the end. 
if someone could find the hourly regression that would help

Comment 5

[hhh]

You're right, Marco, it works using build [ Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008012900 Minefield/3.0b3pre ], I just couldn't tell with bugs 389290 and 405969 in play. I'll have an hourly regression in a bit.

Comment 6

[hhh]

I'm seeing it on XP as regressing between these hourlies...
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008012911 Minefield/3.0b3pre
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008012912 Minefield/3.0b3pre

Comment 7

[Peter van der Woude [:Peter6]]

when dragging the bookmark i get

Error: [Exception... "'Container view not found' when calling method: [nsINavHistoryResultViewer::itemRemoved]"  nsresult: "0x8057001e (NS_ERROR_XPC_JS_THREW_STRING)"  location: "JS frame :: file:///C:/programmas/firefox/components/nsPlacesTransactionsService.js :: PMIT_doTransaction :: line 445"  data: no]
Source File: file:///C:/programmas/firefox/components/nsPlacesTransactionsService.js
Line: 445

Comment 8

[Peter van der Woude [:Peter6]]

(In reply to comment #6)
> I'm seeing it on XP as regressing between these hourlies...
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008012911
> Minefield/3.0b3pre
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008012912
> Minefield/3.0b3pre
> 
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=1201634340&maxdate=1201637159&cvsroot=%2Fcvsroot

which points at Bug 412148

Comment 9

[hhh]

Changed the bug title and OS, I can confirm this on Linux. When you grab a bookmark to DnD in Linux, the Bookmarks Menu disappears, leaving you with no apparent options.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008020614 Minefield/3.0b4pre

Comment 10

[Aaron Train [:aaronmt]]

I wasn't able to replicate this issue in 

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3

Just to confirm, this is in the Library menu?

For me, shifting the middle bookmark to the top performed as expected.

Comment 11

[Marco Bonardo [:mak]]

Aaron, this is when you drag & drop in the Bookmarks MENU, not in the Library

Comment 12

[Marco Bonardo [:mak]]

Attachment: i love typos, don't you?

Comment 13

[Dietrich Ayala (:dietrich)]

Comment on attachment 302792 [details] [diff] [review]
i love typos, don't you?

r=me

Comment 14

[Dietrich Ayala (:dietrich)]

hm, not fixed until checked in!

Comment 15

[M Parker (mparker17)]

I can confirm.

Version: 
- Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3) Gecko/2008020511 Firefox/3.0b3

O/S: 
- Mac OS X version 10.4.11

Machine: 
- 2.16 GHz Intel Core 2 Duo Macbook

Profiles:
- Bug occurs when using a default profile

Themes:
- Bug occurs when using default Firefox theme

Comment 16

[M Parker (mparker17)]

Attachment: Bug confirmed on this buildconfig

Comment 17

[Reed Loden [:reed]]

Checking in browser/components/places/content/controller.js;
/cvsroot/mozilla/browser/components/places/content/controller.js,v  <--  controller.js
new revision: 1.201; previous revision: 1.200
done

Comment 20

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre)
Gecko/2008022704 Minefield/3.0b4pre and Mozilla/5.0 (Macintosh; U; Intel Mac OS
X 10.4; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre

Comment 21

[Tony Chung [:tchung]]

Tracy, how did you verify DnD bookmarks menu works on Mac?  I'm running Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre, and am unable to see this work.

I do confirm, its fixed on Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre

Comment 22

[Tracy Walker [:tracy]]

cut and paste blunder from my verification spree this afternoon.  It's not supposed to work on Mac.  Sorry.

Comment 23

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv