415918 - fix version info on mozcrt19.dll

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

I just noticed that it says "Sample Corporation" in the Company field and "Sample Application DLL" in the Product name field of the version info.  We should make this a little less crappy.

Comment 1

[(not currently active) Ted Mielczarek]

Should just be a matter of patching src/_sample_.rc.

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: patch the version info

Not pretty, but this works for me.

Comment 3

[Benjamin Smedberg]

Comment on attachment 307037 [details] [diff] [review]
patch the version info

I'd prefer "C Runtime" to "CRT", but that's just nitpickery.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 307037 [details] [diff] [review]
patch the version info

a1.9=beltzner

Comment 5

[(not currently active) Ted Mielczarek]

Checked in.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Was it intentional to leave the description intact?
"User-Generated Microsoft (R) C/C++ Runtime Library"

Comment 7

[(not currently active) Ted Mielczarek]

That sounded ok to me, you're welcome to attach a followup patch to change that as well.