416055 - Beta 3 l10n builds are missing the Application Folder icon

Status: VERIFIED FIXED

(Firefox :: Installer, defect, P1)

Description

[Tony Chung [:tchung]]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3) Gecko/2008020511 Firefox/3.0b3
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3) Gecko/2008020511 Firefox/3.0b3

For the beta 3 l10n builds on mac, the installer is missing the Applications folder in the window.   Repros on Mac 10.4 and Mac 10.5.  

** See screenshot.  note that en-US does not have this problem.

Reproducible: Always

Steps to Reproduce:
1. download a mac locale build from the beta 3 rc3 directory.  (eg. ja-JP, de)
2. unpack the archive, and accept the EULA
3. Verify in the installer, the Mac Application folder is missing
Actual Results:  
Missing Application folder where the installer gets dragged to.

Expected Results:  
Application folder is there.

Comment 1

[Tony Chung [:tchung]]

Attachment: Missing Application folder screenshot

Comment 2

[Reed Loden [:reed]]

Attachment: patch - v1

Simple as this?

Basically, bug 320155 added the symlink to browser/installer/Makefile.in but not to browser/locales/Makefile.in. :(

Comment 3

[Mark Mentovai]

Comment on attachment 301813 [details] [diff] [review]
patch - v1

Yeah, that's the stuff

Comment 4

[Reed Loden [:reed]]

Checking in browser/locales/Makefile.in;
/cvsroot/mozilla/browser/locales/Makefile.in,v  <--  Makefile.in
new revision: 1.59; previous revision: 1.58
done

Comment 5

[Tony Chung [:tchung]]

This doesnt look right.  See screenshot for ja on latest nightly.   Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008021604 Minefield/3.0b4pre

Comment 6

[Tony Chung [:tchung]]

Attachment: ja b4pre screenshot

Comment 7

[Reed Loden [:reed]]

What do you see on en-US nightly (for comparison)?

What's the user agent on the ja nightly you're using?

Comment 8

[Samuel Sidler (old account; do not CC)]

Tony, the beta 3 en-US disk image doesn't have the word "Applications" on it. I don't believe there is supposed to be a label, per the mockup given in bug 320155. If you believe it should say "Applications", I think you should file a new bug for that.

Comment 9

[Tony Chung [:tchung]]

Missing the label is not the bug.  It's missing the background image from beta 3 is what i'm complaining about -- https://bugzilla.mozilla.org/attachment.cgi?id=299926.

Comment 10

[Samuel Sidler (old account; do not CC)]

The background image will only appear in branded builds. Nightlies aren't branded.

Comment 11

[Reed Loden [:reed]]

(In reply to comment #10)
> The background image will only appear in branded builds. Nightlies aren't
> branded.

Yes, I really hope we're not saying "Firefox" on unofficial builds. If we are, that's a bug. Could somebody post a screenshot of the Mac installer on en-US for a current nightly for comparison?

Comment 12

[Tony Chung [:tchung]]

Attachment: b4pre enUS nightly mac installer screenshot

en-US nightly installer screenshot

Comment 13

[Reed Loden [:reed]]

So, what's the problem? They look the same to me, except in the ja screenshot, you have the Applications icon selected so that you see the blank name for it.

Comment 14

[Samuel Sidler (old account; do not CC)]

This bug is fixed.

Tony, the "issue" you're seeing is expected. Branding only displays on official builds. Nightlies have never had branding including background dmgs (go download a branch nightly and compare it to Firefox 2.0.0.12).

Comment 15

[Tony Chung [:tchung]]

alright then.  will check this on beta 4 rc.  

Comment 16

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; es-ES; rv:1.9b4) Gecko/2008030317 Firefox/3.0b4.   Symlink for locales are fixed.