416067 - certutil -L -h token doesn't report token authentication failure

Status: RESOLVED FIXED

(NSS :: Tools, defect, P2)

Description

[Julien Pierre]

I was running

certutil -d . -L -h "Sun Metaslot"

The following (roughly) code sequence is executed by certutil is :
NSS_Initialize
PK11_Authenticate(metaslot, ..)
PK11_ListCertsInSlot(metaslot)

The PK11_Authenticate in my case call failed due to bug 396999 . But certutil ignored the error and tried to list the certs in the slot anyway, and ended up reporting "problem printing certificate nicknames" .

I will attach a fix for this.

Comment 1

[Julien Pierre]

Attachment: Report PK11_Authenticate failures

I found more than one such silent authentication error case, so I fixed them all in this patch.

Comment 2

[Robert Relyea]

Comment on attachment 301828 [details] [diff] [review]
Report PK11_Authenticate failures

r+ 

optional enhancement:

Add the token name to the SECU_PrintError...

SECU_PrintError(progName, "could not authenticate to token or database name %s.", PK11_GetTokenName(slot));

Comment 3

[Julien Pierre]

Attachment: Add Bob's suggestion

As checked in to the trunk.

Checking in certutil.c;
/cvsroot/mozilla/security/nss/cmd/certutil/certutil.c,v  <--  certutil.c
new revision: 1.128; previous revision: 1.127
done

Nelson, please review for the branch.

Comment 4

[Julien Pierre]

Thanks, Nelson. As it turns out, this patch doesn't apply directly to the branch because your first patch for bug 291384 isn't on the branch yet. I'll wait until that bug is resolved to check in my patch.

Comment 5

[Julien Pierre]

I checked in the patch to NSS_3_11_BRANCH :

Checking in certutil.c;
/cvsroot/mozilla/security/nss/cmd/certutil/certutil.c,v  <--  certutil.c
new revision: 1.97.2.13; previous revision: 1.97.2.12
done