416230 - Changing Safebrowsing to "Check by Google for each visit.." cause JavaScript Error: "this.getKeyURL is not a function"

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Carsten Book [:Tomcat]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4pre) Gecko/2008020717 Firefox/3.0b4pre (Debug Build)

Steps to reproduce:
* New Profile
* Go into Options -> Security 
* Change the Pref in Safe Browsing to "Check by google for each visit.."
Close Options Window

JS Error:

* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "this.getKeyURL is not a function" {file: "file:///debug/mozilla/firefox-10.5-debug/dist/FirefoxDebug.app/Contents/MacOS/components/nsSafebrowsingApplication.js" line: 994}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://global/content/bindings/preferences.xml :: set_valueFromPreferences :: line 304"  data: yes]

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Looks like bug 402611 removed the function definition, but not that caller.

Comment 2

[Reed Loden [:reed]]

Will bug 388652 fix this?

Comment 3

[Johnathan Nightingale [:johnath]]

(In reply to comment #2)
> Will bug 388652 fix this?

Yep.  You just collided me saying the same thing.  :)

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Fixed by bug 388652?

Comment 5

[Johnathan Nightingale [:johnath]]

(In reply to comment #4)
> Fixed by bug 388652?

Yes, this pref no longer exists to be set to the wrong values.