416270 - [10.5] dmg icon should include a 512x512 version

Status: RESOLVED FIXED

(Camino Graveyard :: General, enhancement)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I don't know that people will see it that often, so it's not critical, but the other kids are doing it, and we should, too, at some point.

Comment 1

[Samuel Sidler (old account; do not CC)]

Yeah, I think I can do this... I'll reassign if not.

Comment 2

[philippe (part-time)]

Taking, hoping Sam will not be real mad angry at me…

Comment 3

[philippe (part-time)]

Attachment: updated icns file

With 512x512, 256x256, 128x128, 32x32 and 16x16 icons
All generated from optimized png's for the individual icons

I've included a 256x256 icon here, although:
1. the default blank icns file shipped by OS X 10.6+ does not include a 256x256 icon)
2. 10.6+ rarely make use of this image. The preview in Finder windows in Column view maxes out at 256x256 (10.7) / 128x128 (10.6). 10.7 uses the 512x512 icon for the larger view, I haven't been able to see it use the 256x256 icon (with a custom made file…). In Icon view the 256x256 icon is used. Mounted on the desktop, the icon size is capped at 128x128.

But given the persistent rumors of highDPI screens / machines coming, it might not be a bad idea to include it (I assume Apple will use the same trick as on iOS: @x2 - I noticed that the Xcode 4.2 Icon Composer offers an option to include a 1024x1024 icon… Afaict, none of the icns file shipping with 10.7.3 include an icon that size, though - I only found one Apple app that has such a beast: Launchpad).

Comment 4

[philippe (part-time)]

Attachment: screenshot in Icon Composer

Screenshot of the individual icons seen in Icon Composer.

Comment 5

[philippe (part-time)]

Attachment: alt updated icns file [landed]

As an alternative, the icns file without 256x256 icon. The file is 35Kb smaller.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 601894 [details]
updated icns file

r=ardissone

Both look fine; I'll let Stuart make the call on whether having the 256x256 member is worth the 35K.

Comment 7

[Stuart Morgan]

Comment on attachment 601894 [details]
updated icns file

I vote no on the 256; if it's rarely used, let's just let interpolation handle it.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed attachment 601896 [details] as http://hg.mozilla.org/camino/rev/e97fe75587f2

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Color shift

So, I noticed when I mounted 2.1.2rc on my Desktop that the .dmg icon color appeared to have shifted some, and, sure enough, it appears to be more aqua than the old icon.  (Also, the edges aren't quite as smooth.)

I don't know how I didn't catch either of those when I was reviewing :-(

Comment 10

[philippe (part-time)]

Attachment: icns file v2

(In reply to Smokey Ardisson (not following bugs - do not email) from comment #9)

> So, I noticed when I mounted 2.1.2rc on my Desktop that the .dmg icon color
> appeared to have shifted some, and, sure enough, it appears to be more aqua
> than the old icon.  (Also, the edges aren't quite as smooth.)

1. the default (blank) dmg icons as shipped by Apple are apparently generated from the largest image (this goes back all the way to 10.5 at least). Those jaggy edges are only really visible on flat light coloured backgrounds, btw. 10.3.9 to the rescue! I fetched the 128x128 and 32x32 images from that .icns file…

2. colour shift: I've no idea what happened :-(.
Hopefully the  attached .icns file looks ok on someone else system.

Comment 11

[philippe (part-time)]

Attachment: icns file v2b

with a minor tweak to the 32px icon

Comment 12

[philippe (part-time)]

Attachment: icns file v2c

with more slight tweaks to the 32px icon

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 604840 [details]
icns file v2c

This seems to be the best compromise between icon position and color fidelity on the 32x32 icon (with no color shift), and smoothes out the jagged edges on both sizes in question.

I'm not sure whether I'm sorry I didn't catch this before or not; it seems like either way there's been a lot of hair pulled to get here :(

Comment 14

[Stuart Morgan]

Comment on attachment 604840 [details]
icns file v2c

sr=smorga

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/1ba7e1f6f5df :)