416377 - Have make clean etc. clean up more.

Status: RESOLVED FIXED

(Directory :: LDAP C SDK, defect)

Description

[jag (Peter Annema)]

Attachment: Use unallmakefiles technique, rm $(DLLLDIF)

Spun off per bug 333308 comment 31.

After make distclean there's still some stuff left. See attached patch for more thorough clean-up of directory/c-sdk.

Comment 1

[Mark Smith [:mcs]]

CC'ing Rich (who has done a lot of make-related work on the LDAP C SDK).

Comment 2

[Mark Smith [:mcs]]

Comment on attachment 302139 [details] [diff] [review]
Use unallmakefiles technique, rm $(DLLLDIF)

Looks OK to me.  Rich, if you have time to take a look that would be great.

Comment 3

[jag (Peter Annema)]

If there's no objections, let's get this checked in.

Since this code is pulled by tag, what's the normal process for getting this into the Mozilla trunk?

Comment 4

[Rich Megginson]

Yep, patch looks good.  Please commit to mozilla/directory/c-sdk CVS HEAD.

You'll probably have to contact Mark B. about getting this into the client branch.

Comment 5

[jag (Peter Annema)]

Checking in directory/c-sdk/Makefile.in;
/cvsroot/mozilla/directory/c-sdk/Makefile.in,v  <--  Makefile.in
new revision: 5.4; previous revision: 5.3
done
Checking in directory/c-sdk/configure;
/cvsroot/mozilla/directory/c-sdk/configure,v  <--  configure
new revision: 5.67; previous revision: 5.66
done
Checking in directory/c-sdk/configure.in;
/cvsroot/mozilla/directory/c-sdk/configure.in,v  <--  configure.in
new revision: 5.61; previous revision: 5.60
done
Checking in directory/c-sdk/config/config.mk;
/cvsroot/mozilla/directory/c-sdk/config/config.mk,v  <--  config.mk
new revision: 5.4; previous revision: 5.3
done
Checking in directory/c-sdk/config/rules.mk;
/cvsroot/mozilla/directory/c-sdk/config/rules.mk,v  <--  rules.mk
new revision: 5.9; previous revision: 5.8
done
Checking in directory/c-sdk/ldap/libraries/libldif/Makefile.in;
/cvsroot/mozilla/directory/c-sdk/ldap/libraries/libldif/Makefile.in,v  <--  Makefile.in
new revision: 5.9; previous revision: 5.8
done

How would I get in touch with Mark B.?

Comment 6

[Mark Banner (:standard8)]

(In reply to comment #5)
> How would I get in touch with Mark B.?

By getting him to read his email ;-)

I think it is fine for this to go in to the client branch.

Comment 7

[jag (Peter Annema)]

Want me to do that? Would any of you prefer to do it yourself? I'm assuming the client branch here is LDAPCSDK_6_0_3_CLIENT_BRANCH.