416381 - Organize > Move bookmark to Toolbar Folder results in misplaced bookmark

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Tracy Walker [:tracy]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008020804 Minefield/3.0b4pre  Marcia also reported this against b3rc3

1) Bookmark a page into say unfiled folder (click star once)
2) Go to Library, select that bookmark in the Unfiled Bookmarks folder
3) Select Organize > Move
4) In the resulting dialog, select the Bookmarks Toolbar folder, click OK

tested results:
the bookmark does not get moved to the Bookmarks Toolbar.  Go to the bookmarked page. notice it is still "Starred." click on the star. notice the Folder: is blank. not really data loss, but rather data misplacement.

expected results: the bookmark is moved to the Bookmarks Toolbar and appears in the folder for it.

Comment 2

[Asaf Romano (gone)]

Attachment: patch

Yay, I managed to write a one-liner patch despite Michael's disturbances...

Comment 3

[Asaf Romano (gone)]

mozilla/browser/components/places/content/moveBookmarks.js 1.14

Comment 4

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre)
Gecko/2008022704 Minefield/3.0b4pre and Mozilla/5.0 (Macintosh; U; Intel Mac OS
X 10.4; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv