416422 - Rejecting edits doesn't remove it from history

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Chris Ilias [:cilias]]

There was spam on the profiles article. I rejected the edit by rolling back to an earlier version. The result was a new edit, which then had to be approved. The rejected edits are still part of history, and as a result the spammer is part of the credits on the live version.

Comment 1

[Nelson Ko [:nkoth]]

i believe as the admin, you can select certain versions and specifically remove those while viewing history, instead of using the usual approve method. You can still do that for the new approved page.

Comment 2

[Nelson Ko [:nkoth]]

you probably wouldn't want normal approvers to have this ability, though. So you might need a reject button or something for that. 

Comment 3

[David Tenser [:djst]]

Can this bug be clarified? Chris, is this big enough a problem to warrant a need for a specific "spam removal reject button," or is it fine to just remove it from history?

Comment 4

[Chris Ilias [:cilias]]

Rejecting an edit consists of the following steps:

On the staging copy, click "remove" in the actions box to rollback to the previous edit; or if there is more than one edit, click on "history", then click on "b" beside the latest good version, to rollback to the latest good version.
Result: rather than the bad edits being removed, a new edit is added, with [rollback version ##].

If that were approved, all edits (rollback and bad edits) are approved, and as a result the person making the bad edit is added to the credits of the live article.

So the next step in rejecting an edit, before approving the rollback, is to go to the article history, check mark the bad edit(s), and click [del], to delete the edit(s) from the article history.

For example, see <http://support.mozilla.com/tiki-pagehistory.php?locale=en-US&page=*Profiles>. Notice that there is no version 15 or 16.

It's a long-winded process. We need a 'reject edit' link/button, that will take care of all of that.

Comment 5

[David Tenser [:djst]]

What we need, then, is a reject button/link that would revert the changes and remove the credit. To solve the spam issue, there should be an option (checkbox) to completely remove the revision from history.

We could morph the bug into this.

Comment 6

[David Tenser [:djst]]

This is only really needed for removing credit from people spamming articles.

Comment 7

[Paul Craciunoiu [:paulc]]

What's the status of this? It may affect how to solve bug 444111.

Comment 9

[Chris Ilias [:cilias]]

Fixed by bug 446082.