416448 - Bookmark data is dynamically saving in Address Bar's (Star Icon) despite losing focus

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect)

Description

[Aaron Train [:aaronmt]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3

I am attempting this on Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3

Changing a bookmarks name in the star icon's menu and losing focus or hitting escape saves the new data instead of discarding it.

Reproducible: Always

Steps to Reproduce:
1. Open a bookmarked page.
2. Click the star icon on the address bar.
3. Change the bookmark name.
4. Press ESCAPE or lose focus of the window.
Actual Results:  
The new entered name was saved instead of being discarded.

Expected Results:  
Revised Bookmark info should be discarded.

Comment 1

[Aaron Train [:aaronmt]]

Adding any tags or changing folder replicates the problem too, not just the Bookmark Name field.

Comment 2

[Marcia Knous [:marcia]]

Confirming. I see this as well using  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3) Gecko/2008020511 Firefox/3.0b3. I guess I would expect if you used the ESC key that it would revert to the bookmark name that you had previously given, but it seems the changes are taking place dynamically.

Comment 4

[Aaron Train [:aaronmt]]

Is this bug forgotten about, is it being looked after? Currently still exists in Beta 5 and I am viewing it in an Ubuntu release.

Comment 5

[Aaron Train [:aaronmt]]

Still an issue on trunk build, Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1) Gecko/2008072820 Firefox/3.0.1

Comment 6

[Marco Bonardo [:mak]]

if this is still valid in 3.1beta, it would be better investigating it, asking blocking, we should not save changes if the users does not confirm them.

Comment 7

[Aaron Train [:aaronmt]]

You're right, user changes should not take effect unless you click 'Done'. Although I have no confirmation if it was intended to do this. That would imply  that the user has already decided in the first place to click the icon, they made changes, they will most likely go back and correct them - so its saving their changes with the intent that the user will update them as is.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Blocking for investigation, but I can't confirm it on nightlies; are we sure that this isn't already fixed?

Comment 9

[Aaron Train [:aaronmt]]

I am trying this on Nov 9th nightly.

1. After making a change to the name of a bookmark and hitting ESCAPE, the changes are now *not* dynamically saving.

2. Losing focus to the window - changes *are* dynamically saved.

3. Clicking Cancel does not dynamically save the name.

So... yes, this seems to be fixed - although #2 - losing focus to the star icon window still dynamically saves bookmark data - is this intentional?

Comment 11

[Dietrich Ayala (:dietrich)]

(In reply to comment #9)
> So... yes, this seems to be fixed - although #2 - losing focus to the star icon
> window still dynamically saves bookmark data - is this intentional?

This is intentional. This dialog applies changes instantly, so the only scenario in which changes should be discarded is if the user explicitly takes action to do so via Escape or Cancel.

Comment 12

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv