Closed
Bug 416457
Opened 17 years ago
Closed 17 years ago
Wrong favicon displayed on Wikipedia page
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mcsmurf, Assigned: Callek)
References
Details
(Keywords: regression)
Attachments
(1 file, 2 obsolete files)
|
2.90 KB,
patch
|
Callek
:
review+
Callek
:
superreview+
|
Details | Diff | Splinter Review |
To reproduce:
1. Go to http://de.wikipedia.org/wiki/Ethanthiol
2. Compare favicon with another browser
Results:
SeaMonkey displays the icon specified under
<link rel="apple-touch-icon" href="http://de.wikipedia.org/apple-touch-icon.png" />
It should probably display the favicon.ico icon like Firefox trunk does.
|
||
Comment 1•17 years ago
|
||
I think this is because we changed the regexps from ^|\s...\s|$ to \b...\b
|
Assignee | |
Comment 2•17 years ago
|
||
This appears to have regressed from Bug 240393.
Blocks: 240393
Keywords: regression
|
|
Assignee | |
Comment 3•17 years ago
|
||
Assignee: nobody → bugspam.Callek
Status: NEW → ASSIGNED
Attachment #303954 -
Flags: superreview?(neil)
Attachment #303954 -
Flags: review?(neil)
|
|
||
Comment 4•17 years ago
|
||
Comment on attachment 303954 [details] [diff] [review]
Fix regexes
Aren't there other regexes that need fixing? See
http://mxr.mozilla.org/mozilla/search?string=test%28rel%29&find=suite&findi=&filter=%5C%5Cb%5C%2F&tree=mozilla
(It also looks as if some of them are missing /i.)
Attachment #303954 -
Attachment description: Fix regex's → Fix regexes
Attachment #303954 -
Flags: superreview?(neil)
Attachment #303954 -
Flags: superreview-
Attachment #303954 -
Flags: review?(neil)
Attachment #303954 -
Flags: review+
|
|
||
Comment 5•17 years ago
|
||
If you prefer, you can fix page info in a separate patch, and then sr=me.
|
|
Assignee | |
Comment 6•17 years ago
|
||
Adding pageinfo to this patch was easier...
Attachment #303954 -
Attachment is obsolete: true
Attachment #304085 -
Flags: superreview?(neil)
Attachment #304085 -
Flags: review?(neil)
|
|
||
Comment 7•17 years ago
|
||
Comment on attachment 304085 [details] [diff] [review]
fix regexes (pageinfo too)
(note that I haven't actually tested page info as such)
Attachment #304085 -
Flags: superreview?(neil)
Attachment #304085 -
Flags: superreview+
Attachment #304085 -
Flags: review?(neil)
Attachment #304085 -
Flags: review+
|
|
Assignee | |
Comment 8•17 years ago
|
||
accidentally left out the addition of the case insensitive flags on the pageinfo changes. Porting r/sr.
Attachment #304085 -
Attachment is obsolete: true
Attachment #304151 -
Flags: superreview+
Attachment #304151 -
Flags: review+
|
|
Assignee | |
Updated•17 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•17 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 9•17 years ago
|
||
Checking in suite/browser/tabbrowser.xml;
/cvsroot/mozilla/suite/browser/tabbrowser.xml,v <-- tabbrowser.xml
new revision: 1.194; previous revision: 1.193
done
Checking in suite/browser/pageinfo/pageInfo.js;
/cvsroot/mozilla/suite/browser/pageinfo/pageInfo.js,v <-- pageInfo.js
new revision: 1.10; previous revision: 1.9
done
Checking in suite/browser/pageinfo/feeds.js;
/cvsroot/mozilla/suite/browser/pageinfo/feeds.js,v <-- feeds.js
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•