416457 - Wrong favicon displayed on Wikipedia page

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Frank Wein [:mcsmurf]]

To reproduce:
1. Go to http://de.wikipedia.org/wiki/Ethanthiol
2. Compare favicon with another browser

Results:
SeaMonkey displays the icon specified under
<link rel="apple-touch-icon" href="http://de.wikipedia.org/apple-touch-icon.png" />
It should probably display the favicon.ico icon like Firefox trunk does.

Comment 1

[[e-mail]]

I think this is because we changed the regexps from ^|\s...\s|$ to \b...\b

Comment 2

[Justin Wood (:Callek)]

This appears to have regressed from Bug 240393.

Comment 3

[Justin Wood (:Callek)]

Attachment: Fix regexes

Comment 4

[[e-mail]]

Comment on attachment 303954 [details] [diff] [review]
Fix regexes

Aren't there other regexes that need fixing? See

http://mxr.mozilla.org/mozilla/search?string=test%28rel%29&find=suite&findi=&filter=%5C%5Cb%5C%2F&tree=mozilla

(It also looks as if some of them are missing /i.)

Comment 5

[[e-mail]]

If you prefer, you can fix page info in a separate patch, and then sr=me.

Comment 6

[Justin Wood (:Callek)]

Attachment: fix regexes (pageinfo too)

Adding pageinfo to this patch was easier...

Comment 7

[[e-mail]]

Comment on attachment 304085 [details] [diff] [review]
fix regexes (pageinfo too)

(note that I haven't actually tested page info as such)

Comment 8

[Justin Wood (:Callek)]

Attachment: fix regexes (pageinfo too) [with case insensitive regexes]

accidentally left out the addition of the case insensitive flags on the pageinfo changes.  Porting r/sr.

Comment 9

[Justin Wood (:Callek)]

Checking in suite/browser/tabbrowser.xml;
/cvsroot/mozilla/suite/browser/tabbrowser.xml,v  <--  tabbrowser.xml
new revision: 1.194; previous revision: 1.193
done
Checking in suite/browser/pageinfo/pageInfo.js;
/cvsroot/mozilla/suite/browser/pageinfo/pageInfo.js,v  <--  pageInfo.js
new revision: 1.10; previous revision: 1.9
done
Checking in suite/browser/pageinfo/feeds.js;
/cvsroot/mozilla/suite/browser/pageinfo/feeds.js,v  <--  feeds.js
new revision: 1.3; previous revision: 1.2
done