Closed
Bug 416554
Opened 16 years ago
Closed 14 years ago
Missing column sort indicator in Preferences ▸ Privacy ▸ Show Cookies...
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
Firefox 4.0b7
People
(Reporter: adelfino, Assigned: mkohler)
Details
Attachments
(1 file, 1 obsolete file)
1.23 KB,
patch
|
dao
:
review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008020908 Minefield/3.0b4pre Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008020908 Minefield/3.0b4pre There's no way to easily know how a column is sorted in Preferences > Privacy > Show Cookies..., because no glyph appears in the columns. Reproducible: Always
Reporter | ||
Updated•16 years ago
|
Version: unspecified → Trunk
Reporter | ||
Updated•16 years ago
|
Summary: Missing column sort indicator in Preferences > Privacy > Show Cookies... → Missing column sort indicator in Preferences ▸ Privacy ▸ Show Cookies...
Updated•16 years ago
|
Severity: normal → minor
Status: UNCONFIRMED → NEW
Component: General → Preferences
Ever confirmed: true
OS: Linux → All
QA Contact: general → preferences
Hardware: PC → All
Assignee | ||
Comment 1•14 years ago
|
||
Assignee: nobody → michaelkohler
Status: NEW → ASSIGNED
Attachment #456094 -
Flags: review?(gavin.sharp)
Assignee | ||
Updated•14 years ago
|
Whiteboard: [needs review gavin]
Comment 2•14 years ago
|
||
Comment on attachment 456094 [details] [diff] [review] Patch v1 (trivial) >+ this._domainCol = document.getElementById("domainCol"); >+ this._nameCol = document.getElementById("nameCol"); Why aren't these local variables?
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #2) > Comment on attachment 456094 [details] [diff] [review] > Patch v1 (trivial) > > >+ this._domainCol = document.getElementById("domainCol"); > >+ this._nameCol = document.getElementById("nameCol"); > > Why aren't these local variables? Good question. Probably because all other variables around there are global too. I guess I'll need to change that tomorrow and upload a new patch.
Assignee | ||
Updated•14 years ago
|
Whiteboard: [needs review gavin]
Assignee | ||
Comment 4•14 years ago
|
||
Attachment #456094 -
Attachment is obsolete: true
Attachment #483853 -
Flags: review?(dao)
Attachment #456094 -
Flags: review?(gavin.sharp)
Updated•14 years ago
|
Attachment #483853 -
Flags: review?(dao) → review+
Assignee | ||
Comment 5•14 years ago
|
||
Comment on attachment 483853 [details] [diff] [review] Patch v1.1 (trivial) IMHO this is a low risk change.
Attachment #483853 -
Flags: approval2.0?
Updated•14 years ago
|
Attachment #483853 -
Flags: approval2.0? → approval2.0+
Updated•14 years ago
|
Keywords: checkin-needed
Comment 6•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/52811d688f2b
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
Updated•14 years ago
|
Target Milestone: Firefox 4.0b8 → Firefox 4.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•