416554 - Missing column sort indicator in Preferences ▸ Privacy ▸ Show Cookies...

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Andrés Delfino]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008020908 Minefield/3.0b4pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008020908 Minefield/3.0b4pre

There's no way to easily know how a column is sorted in Preferences > Privacy > Show Cookies..., because no glyph appears in the columns.

Reproducible: Always

Comment 1

[Michael Kohler [:mkohler]]

Attachment: Patch v1 (trivial)

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 456094 [details] [diff] [review]
Patch v1 (trivial)

>+    this._domainCol = document.getElementById("domainCol");
>+    this._nameCol = document.getElementById("nameCol");

Why aren't these local variables?

Comment 3

[Michael Kohler [:mkohler]]

(In reply to comment #2)
> Comment on attachment 456094 [details] [diff] [review]
> Patch v1 (trivial)
> 
> >+    this._domainCol = document.getElementById("domainCol");
> >+    this._nameCol = document.getElementById("nameCol");
> 
> Why aren't these local variables?

Good question. Probably because all other variables around there are global too. I guess I'll need to change that tomorrow and upload a new patch.

Comment 4

[Michael Kohler [:mkohler]]

Attachment: Patch v1.1 (trivial)

Comment 5

[Michael Kohler [:mkohler]]

Comment on attachment 483853 [details] [diff] [review]
Patch v1.1 (trivial)

IMHO this is a low risk change.

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/52811d688f2b