Closed Bug 416710 Opened 17 years ago Closed 17 years ago

When opening a tab in the foreground, we set selectedTab twice

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 beta4

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Seems like the asynchronous code from bug 249136 isn't needed anymore, otherwise the synchronous code from bug 308396 (see bug 308396 comment 47 in particular) would already trigger that bug.
Attachment #302435 - Flags: review?(gavin.sharp)
Summary: When open a tab in the foreground, we set selectedTab twice → When opening a tab in the foreground, we set selectedTab twice
Comment on attachment 302435 [details] [diff] [review] patch Man, I've noticed this bug, when I open a new tab and then quickly switch away, only to have it selected again, but I never looked into it :( I wonder whether we should take this bug on the branch.
Attachment #302435 - Flags: review?(gavin.sharp) → review+
Attachment #302435 - Flags: approval1.9?
Attachment #302435 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in browser/base/content/tabbrowser.xml; /cvsroot/mozilla/browser/base/content/tabbrowser.xml,v <-- tabbrowser.xml new revision: 1.261; previous revision: 1.260 done
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: wanted1.8.1.x?
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: