416727 - [10.5] Fix tabbing into the Pop-up Exceptions List Policy column

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On 10.5 with the new table tabbing impl, we tab into all "editable" table cells in a row.

In the Pop-up Exceptions List table (and in the Flashblock one implemented in bug 371895), we tab into the Policy column cells and make them ready for text entry, except that column doesn't accept text entry, only changes to the policy.

By contrast, the Cookies Exceptions list works correctly; you can tab into the cells in the Policy column and they become focused, but editing does not begin; instead, pressing <space> pops up the menu that allows you to change the Policy.

I don't know if this might require nib changes or not, so flagging 1.6b3? until someone looks at it.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Bug 370119 might ultimately take care of this, but if we can easily improve this bit of the UI for 1.6, it might be worthwhile.

Comment 2

[Sean Murphy]

We can fix this by setting the policy column as not editable.  Due to the changes to tabbing behavior in Leopard, having a NSPopupButtonCell in an editable column seems to cause this problem.  The cookies exceptions list is un-editable, and does what we want.

Comment 3

[Sean Murphy]

Actually, should we just fix this over on bug 371895, since it's touching WebFeatures.nib?

If so, we just need to uncheck "editable" on the exceptions table column.  I should mention that doing so won't affect the actual editable status of the NSPopupButtonCell data cell, it merely allows for proper tabbing behavior.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #3)
> Actually, should we just fix this over on bug 371895, since it's touching
> WebFeatures.nib?
> 
> If so, we just need to uncheck "editable" on the exceptions table column.

If that's all, yeah; I'll post a new nib there this afternoon.

(If we don't get bug 371895 for 1.6, we should do this separately, but for the moment, I prefer not to bitrot Bryan's nibwork.)

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Fixed nib

Since bug 371895 is now unlikely for 1.6, this just flips the editable bit on that column in the current nib.

Comment 6

[Jeff Dlouhy]

Comment on attachment 304648 [details]
Fixed nib

r=jeff

Comment 7

[Stuart Morgan]

Comment on attachment 304648 [details]
Fixed nib

sr=smorgan. What a lame definition of "editable"...

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in on the trunk and MOZILLA_1_8_BRANCH.