416731 - When an update has been downloaded, dialog text refers to a "Later" button, should be "Not Now"

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

The name of the button has been changed in bug 391598 (attachment 299253 [details] [diff] [review]). &finishedBackground.more2; slipped through.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 302476 [details] [diff] [review]
patch

Changing finishedBackground.more1 without the string having changed creates more work for localizers. I'm not sure string naming consistency is worth the trouble, but I guess they're going to have to load up this file anyways to make the other change...

Can you add a localization note that says something like "This string describes the button label defined by notNowButton in chrome/mozapps/update/updates.properties."?

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch v2

(In reply to comment #1)
> (From update of attachment 302476 [details] [diff] [review])
> Changing finishedBackground.more1 without the string having changed creates
> more work for localizers. I'm not sure string naming consistency is worth the
> trouble, but I guess they're going to have to load up this file anyways to make
> the other change...

Given that we're past string freeze, I reverted this.

> Can you add a localization note that says something like "This string describes
> the button label defined by notNowButton in
> chrome/mozapps/update/updates.properties."?

Done. (I wrote updates.properties without the path, because it's the same directory.)

Comment 3

[Reed Loden [:reed]]

Checking in toolkit/locales/en-US/chrome/mozapps/update/updates.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/update/updates.dtd,v  <--  updates.dtd
new revision: 1.31; previous revision: 1.30
done
Checking in toolkit/mozapps/update/content/updates.xul;
/cvsroot/mozilla/toolkit/mozapps/update/content/updates.xul,v  <--  updates.xul
new revision: 1.34; previous revision: 1.33
done

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008022304 Minefield/3.0b4pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008022404 Minefield/3.0b4pre

-and-

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008022204 Minefield/3.0b4pre