416732 - horizontal placement of bullet only considers floats aligned with top pixel of list item whose first child is a block

Status: NEW

(Core :: Layout: Block and Inline, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase

In bug 413840 comment 12, I wrote:
> It's still not quite optimal -- we use the floats present at the top of the
> block when the bullet is placed for the baseline of a child block.  (I could
> also use the baseline, but that would break some (more?) cases to fix others.) 
> We really need bug 25888 here, plus a function to get the full height of the
> line the bullet is associated with.  I should file a followup bug on this.  But
> I don't want to try to do too much for 1.9.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Steps to reproduce: load attachment 302478 [details]

Actual results: bullet overlaps select

Expected results: bullet to the left of select, like it is when the div is removed:
http://mxr.mozilla.org/seamonkey/source/layout/reftests/bugs/413840-pushed-line-bullet.html

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

... and we really need to test things here for all three cases of bullet placement.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This bug should cover what I described as patch 5 in bug 25888 comment 41.

In bug 25888 comment 60, I wrote:
>Bug 179596 comment 26 has some thoughts relevant to fixing this for horizontal positioning of bullets
>(intended to be patch 5 in the series above, but which I've never started on).

Comment 4

[Mike Kaply [:mkaply]]

The bullet no longer overlaps the select in the testcase. Is this fixed?

Note that for some reason, chrome doesn't show the bullet at all.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There are probably still some other cases to test.  (It would also be interesting to see what fixed it; it wasn't bug 1291110.)

Comment 6

[Mike Kaply [:mkaply]]

It was fixed a very long time ago. A patch between 2008-04-27 and 2008-04-29. That's all I could get out of mozregression.