416755 - Aqua focus ring on Google.com input field overlaps buttons

Status: NEW

(Core :: Widget: Cocoa, defect, P3)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Safari 3 vs Firefox 3.0b4pre

STR:

1. http://www.google.com
2. Compare to Safari 3

ER: Whitespace between the input's focus ring and the buttons
AR: Buttons draw on top of the focus ring and there's no whitespace between the ring and the buttons.

I'm not positive the problem is the focus ring; looking at the comparison shot, it looks like our input both 1) is taller than Safari's and 2) has more padding, especially on the bottom.

Note that although these windows have been reduced to facilitate easy comparison, the problem exists even when the window takes up the entire screen.

Comment 1

[philippe (part-time)]

I'm pretty sure the display in Safari/WebKit is caused by the default margins on form-controls in that browser (approx. 0.5ex on each side).

I don't see that overlap here, as I have set some margins on form-controls in my usercontent.css. Forcing Webkit to use 0 margins gives the same result as Gecko.

Comment 2

[philippe (part-time)]

Attachment: test case

Click in each of the two text fields. The focus ring on the second one is overlapped by the submit buttons in WebKit (latest) and Safari 3.04.

Comment 3

[Nick Woods]

I ran into this same problem today and found this ticket.  I don't know if anyone has figured out the issue but it's a pretty glaring problem given that it happens with the main Google homepage with the final Firefox 3 release downloaded today.  If you need additional screenshots or anything else let me know.

Comment 4

[Nick Woods]

Oh, and this I noticed the problem with the following browser version info:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9) Gecko/2008061004 Firefox/3.0

and additional system info:

System Version:	Mac OS X 10.5.3 (9D34)
Kernel Version:	Darwin 9.3.0

Comment 5

[Nick Woods]

Attachment: Firefox 3 focus ring overlap picture

Adding my snapshot of the issue as well for good measure.

Comment 6

[Nick Woods]

Attachment: Clipping issue also seen on www.eharmony.com home page with Firefox 3 release candidate Mac

I also noticed a similar sort of clipping issue although slightly different today on the www.eharmony.com home page.  I've attached a snapshot of the problem area.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment 6 looks more like bug 383367, in that the image itself (the whitespace to the left of the green) is clearly well into the <input type="text">.

This bug is really about focus-ring-only overlaps (in the testcases here, there's no overlap unfocused).