416813 - jslock.c does not link on VC7.1 due to use of _InterlockedCompareExchange

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Robert Longson [:longsonr]]

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

Comment 2

[Robert Longson [:longsonr]]

solution based on http://msdn2.microsoft.com/en-us/library/f24ya7ct(VS.71).aspx

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 302587 [details] [diff] [review]
patch

This is one of those "if it works, it doesn't need review." I can rubber-stamp for sure. Only nit-picks: avoid doubled space, use prevailing style for formatting and parameter names:

extern long __cdecl
_InterlockedCompareExchange(long *volatile dest, long exchange, long comp);

/be

Comment 4

[Brendan Eich [:brendan]]

Attachment: with nits picked

I'm assuming the extern doesn't hurt -- please holler if MSVC disagrees.

/be

Comment 5

[Brendan Eich [:brendan]]

Robert, could you please test the revised patch? I'm pretty sure it will work but hate to go in untested. Thanks,

/be

Comment 6

[Robert Longson [:longsonr]]

The patch works fine for me. I'll have to leave it to you to to check in; I just discovered I don't have check in privileges for the Javascript partition.

Comment 7

[Brendan Eich [:brendan]]

Fixed on trunk:

js/src/jslock.c 3.76

with credit to Robert -- thanks!

/be