Closed
Bug 416856
Opened 16 years ago
Closed 16 years ago
Download status listener keeps windows alive until app shutdown
Categories
(Toolkit :: Downloads API, defect, P1)
Toolkit
Downloads API
Tracking
()
RESOLVED
FIXED
mozilla1.9beta4
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
References
Details
Attachments
(1 file, 1 obsolete file)
1.38 KB,
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
Working on making the cycle collector free closed DOM windows I found that the download status panel listener is never removed when the browser closes. This keeps all DOM windows open until the app shuts down and the download manager clears its listener list. We need to figure out a generic way to prevent this sort of thing, but that's for another bug.
Flags: blocking-firefox3?
Attachment #302630 -
Flags: review?(mano)
Comment 1•16 years ago
|
||
Wouldn't it be better to just unregister the listener on window unload?
Assignee | ||
Comment 2•16 years ago
|
||
onunload="BrowserShutdown()", so I think this is doing what you're talking about?
Comment 3•16 years ago
|
||
right, sorry. Missed that.
Comment 4•16 years ago
|
||
Comment on attachment 302630 [details] [diff] [review] Patch, v1 I would rather add an unit method to the listener object, instead of exposing isListening.
Attachment #302630 -
Flags: review?(mano) → review-
Assignee | ||
Comment 5•16 years ago
|
||
Ok, with uninit.
Attachment #302630 -
Attachment is obsolete: true
Attachment #303159 -
Flags: review?(mano)
Comment 6•16 years ago
|
||
Comment on attachment 303159 [details] [diff] [review] Patch, v2 nit: remove the braces in uninit. r=mano otherwise.
Attachment #303159 -
Flags: review?(mano) → review+
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P1
Assignee | ||
Comment 7•16 years ago
|
||
Fixed, thanks!
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 8•16 years ago
|
||
*** VERIFIED I even 100% remember this bug, it's fixed now. Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008030607 Minefield/3.0b5pre -Mike
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•