Closed Bug 416856 Opened 13 years ago Closed 13 years ago

Download status listener keeps windows alive until app shutdown

Categories

(Toolkit :: Downloads API, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9beta4

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch, v1 (obsolete) — Splinter Review
Working on making the cycle collector free closed DOM windows I found that the download status panel listener is never removed when the browser closes. This keeps all DOM windows open until the app shuts down and the download manager clears its listener list.

We need to figure out a generic way to prevent this sort of thing, but that's for another bug.
Flags: blocking-firefox3?
Attachment #302630 - Flags: review?(mano)
Wouldn't it be better to just unregister the listener on window unload?
onunload="BrowserShutdown()", so I think this is doing what you're talking about?
right, sorry.  Missed that.
Comment on attachment 302630 [details] [diff] [review]
Patch, v1

I would rather add an unit method to the listener object, instead of exposing isListening.
Attachment #302630 - Flags: review?(mano) → review-
Attached patch Patch, v2Splinter Review
Ok, with uninit.
Attachment #302630 - Attachment is obsolete: true
Attachment #303159 - Flags: review?(mano)
Comment on attachment 303159 [details] [diff] [review]
Patch, v2

nit: remove the braces in uninit.

r=mano otherwise.
Attachment #303159 - Flags: review?(mano) → review+
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P1
Fixed, thanks!
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
*** VERIFIED
I even 100% remember this bug, it's fixed now.

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008030607 Minefield/3.0b5pre

-Mike
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.