416891 - Change the width of the main div for wide-screen displays in about.css

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[(no longer active)]

Attachment: Patch (v1)

Spinoff from bug 372826 comment 17.

This can happen by using a percent value for max-width style on #aboutPageContainer.  A patch to fix this is attached.

This patch adds the aboutPageWideContainer CSS class to about.css, so that pages which wish to use a wide-screen compatible styling (such as about:license and about:buildconfig in bug 372826) can use this style on their main <div> with id aboutPageContainer.  This is done so that this patch doesn't have any impact on the current about: page.

Gavin: can you review this?  It's pretty simple to review, and has no impact on the current chrome://global/skin/about.css usage.

Comment 1

[Reed Loden [:reed]]

What about pinstripe?

Comment 2

[(no longer active)]

It picks this up from winstripe:

<http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/themes/pinstripe/global/jar.mn&rev=1.38&mark=8>

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Don't we just want this to apply to all about: pages? Which pages would it be unsuitable for?

Comment 4

[Steffen Wilberg]

> Don't we just want this to apply to all about: pages? Which pages would it be
> unsuitable for?
about: looks silly at max-width:80%. You can test that with Firebug.

Comment 5

[(no longer active)]

Yes, that's exactly why I added the change to a separate class, after seeing what it makes about: look like.  :-)

Comment 6

[(no longer active)]

Comment on attachment 302670 [details] [diff] [review]
Patch (v1)

This is a simple change which doesn't have any side effect on the current code, and will be used in bug 372826 for example.  Seeking approval.

Comment 7

[Reed Loden [:reed]]

Checking in toolkit/themes/winstripe/global/about.css;
/cvsroot/mozilla/toolkit/themes/winstripe/global/about.css,v  <--  about.css
new revision: 1.2; previous revision: 1.1
done