416904 - Javascript bookmarklets not ignored by awesomebar auto-complete

Status: RESOLVED DUPLICATE of bug 417798

(Firefox :: Bookmarks & History, defect)

Description

[Jake]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3) Gecko/2008020511 Firefox/3.0b3
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3) Gecko/2008020511 Firefox/3.0b3

I have the "remove redirect" bookmarklet in my bookmarks toolbar. The new iteration of the awesomebar (truly awesome, btw!) will find parts of the javascript code and present this "bookmark" as an option when I type a string such as "scr" into the location bar. Since the bookmarklet is automatically starred (it's treated as a real bookmark) it will consistenly appear at or near the top of the selection list where it only gets in the way. This is annoying and potentially confusing. I cannot imagine a use case where a bookmarklet that is intended to be clicked in the toolbar should appear in auto-complete results.

Reproducible: Always

Steps to Reproduce:
1. Drag/drop javascript bookmarklet to bookmarks toolbar
2. type "scr" or "java" etc. into location bar
3. frown
Actual Results:  
One of the top awesomebar results will be "function(){var%20k,x..."

Expected Results:  
A list of useful search results that I might actually be interested in going to.

Exclude javascript bookmarklets from awesomebar search the same as livemarks. Shouldn't be too hard, as the "javascript:" prefix to the link location clearly says what it is.

Comment 1

[Jesse Ruderman]

I kinda like being able to autocomplete to previously *typed* javascript: URLs.  Autocompleting to bookmarks with javascript: URLs doesn't sound very useful.

Comment 2

[Wes Campaigne]

Using a bookmarklet doesn't create a history entry for itself, and it doesn't increment its visit count / last visit date in Places.

In other words, aside from the fact that it's bookmarked, a bookmarklet should bottom out on the frecency calculations. The desired useful results should start appearing first once Places has the accumulated the data to know better.

At the same time, this means that the awesomebar does *not* remember or autocomplete previously typed javascript: URLs, either. (At least it doesn't under my testing just now.)

Comment 3

[Jake]

This now appears to be fixed in recent nightlies. Resolving as fixed.

Comment 4

[Jesse Ruderman]

Yeah, this was fixed in bug 417798.

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv