416930 - 10.5.2 statusbar text has weird display

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[philippe (part-time)]

Attachment: screenshot

the white 'shadow' is offset more than it used to.

Comment 1

[Stuart Morgan]

Attachment: fix

I guess that answers the question of why I had to use an offset of 2 to get what appeared to be a single pixel of offset.

This doesn't seem worth special-casing; 10.5.[01] users can just get less etching.

Comment 2

[philippe (part-time)]

(In reply to comment #1)
> Created an attachment (id=302744) [details]
> fix
> 
> I guess that answers the question of why I had to use an offset of 2 to get
> what appeared to be a single pixel of offset.

This might provide the answer:
http://islayer.com/blog/?p=255
see first comment

(the bug in WebKit/webcontent has long annoyed me; didn't know it affected chrome parts of apps).

Comment 3

[Stuart Morgan]

Attachment: v2

Or, even better, I can finally find documentation about the right way to do this that I was sure they had mentioned at WWDC but couldn't find when I was looking for it.

This version should be right on all versions of 10.5, past and present.

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 302747 [details] [diff] [review]
v2

sr=pink. me likey ;)

Comment 5

[Stuart Morgan]

Landed on trunk and MOZILLA_1_8_BRANCH.

I also switched MAC_OS_X_VERSION_MIN_REQUIRED to MAC_OS_X_VERSION_MAX_ALLOWED, since it's actually the SDK that we want that block to be conditional on.

Comment 6

[Dave Cook]

Thank you for fixing this so quickly.  And for a great Mac based browser.  Keep up the good work, Dev's.

Comment 7

[philippe (part-time)]

v. with 2.0a1pre (1.9b4pre 2008021420)