Closed Bug 416943 Opened 15 years ago Closed 15 years ago

Places autocomplete fails without pref values

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 beta4

People

(Reporter: matt, Assigned: matt)

References

Details

Attachments

(1 file)

nsNavHistory does not provide a default value for mNumVisitsForFrecency.  As a result, browser history autocomplete is broken for all XULRunner apps missing the "places.frecency.numVisits" preference.
Attachment #302753 - Flags: review?(dietrich)
Blocks: songbird
Comment on attachment 302753 [details] [diff] [review]
I imagine this should do it.

drivers: minor change for toolkit compat.
Attachment #302753 - Flags: review?(dietrich)
Attachment #302753 - Flags: review+
Attachment #302753 - Flags: approval1.9?
Attachment #302753 - Flags: approval1.9? → approval1.9+
Assignee: nobody → matt
Keywords: crash
Hardware: PC → All
Keywords: crash
Checking in toolkit/components/places/src/nsNavHistory.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v  <--  nsNavHistory.cpp
new revision: 1.248; previous revision: 1.247
done
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta4
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.