416958 - Update header names

Status: RESOLVED FIXED

(Core :: XML, defect, P3)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

some of the headers have changed names in the access-control spec. We need to update those. Also, the Method-Check header should be removed, along with using the method as part of the key to the OPTIONS cache.

Surya, wanna have a go. Might be just as easy to do as part of bug 416957, but i wanted to have a separate bug so we don't forget.

Comment 1

[Surya Ismail]

Attachment: Change header names

Comment 2

[Anne (:annevk)]

Surya, btw, I changed Access-Control-Origin so it no longer includes the port if the port is the default port for the scheme. This should make the 95% case easier for Web developers.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

you should also remove the use of the method as part of the key to the OPTIONS cache. Which probably means that you can remove passing the method to the nsACProxyListener entirely.

Comment 4

[Surya Ismail]

Attachment: Corrections

Corrections. Thanks Anne and Jonas.  Sorry for making you guys repeat yourselves.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 303213 [details] [diff] [review]
Corrections

>   uri->GetPort(&port);
>-  if (port == -1) {
>-    port = NS_GetDefaultPort(scheme.get());
>-    if (port == -1) {
>-      return NS_ERROR_DOM_BAD_URI;
>-    }
>+  if (port != -1) {
>+    root.Append(":");
>+    root.AppendInt(port);
>   }

So I don't think this is exactly what you want to do. This'll send out http://foo.com:80 if the user explicitly navigates to :80. Rather you should compare not write out a port if GetPort returns -1 *or* if it returns the same as NS_GetDefaultPort.

r/sr=me with that fixed.

Comment 6

[Surya Ismail]

Attachment: Default port correction

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 303468 [details] [diff] [review]
Default port correction

Sweet, thanks!

Comment 8

[Reed Loden [:reed]]

Checking in content/base/src/nsCrossSiteListenerProxy.cpp;
/cvsroot/mozilla/content/base/src/nsCrossSiteListenerProxy.cpp,v  <--  nsCrossSiteListenerProxy.cpp
new revision: 3.10; previous revision: 3.9
done
Checking in content/base/src/nsXMLHttpRequest.cpp;
/cvsroot/mozilla/content/base/src/nsXMLHttpRequest.cpp,v  <--  nsXMLHttpRequest.cpp
new revision: 1.220; previous revision: 1.219
done
Checking in content/base/src/nsXMLHttpRequest.h;
/cvsroot/mozilla/content/base/src/nsXMLHttpRequest.h,v  <--  nsXMLHttpRequest.h
new revision: 1.69; previous revision: 1.68
done
Checking in content/base/test/file_CrossSiteXHR2_inner.html;
/cvsroot/mozilla/content/base/test/file_CrossSiteXHR2_inner.html,v  <--  file_CrossSiteXHR2_inner.html
new revision: 1.2; previous revision: 1.1
done
Checking in content/base/test/file_CrossSiteXHR3_inner.html;
/cvsroot/mozilla/content/base/test/file_CrossSiteXHR3_inner.html,v  <--  file_CrossSiteXHR3_inner.html
new revision: 1.2; previous revision: 1.1
done
Checking in content/base/test/test_CrossSiteXHR3.html;
/cvsroot/mozilla/content/base/test/test_CrossSiteXHR3.html,v  <--  test_CrossSiteXHR3.html
new revision: 1.2; previous revision: 1.1
done

Comment 9

[Takeshi Kurosawa :takenspc]

sorry, accidental keyword change :-(