417066 - Enable jemalloc by default on Linux

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Stuart Parmenter]

jemalloc. wee.

Comment 1

[Stuart Parmenter]

Attachment: enabling patch

Comment 2

[Stuart Parmenter]

checked in

Comment 3

[Stuart Parmenter]

Attachment: disable jemalloc if trace-malloc is on

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 302939 [details] [diff] [review]
disable jemalloc if trace-malloc is on

Seems better not to silently disable -- I'd change the default of MOZ_MEMORY based on trace-malloc, but make explicitly enabling both give an error...

Comment 5

[Brad Jackson]

My build is trying to link in a static libjemalloc.a, but only the shared libjemalloc.so is being built.

gmake[5]: *** No rule to make target `../../staticlib/libjemalloc.a', needed by `firefox-bin'.  Stop.

Comment 6

[jag (Peter Annema)]

Attachment: Fix static build bustage.

r=/sr=/a=pavlov on irc

Checking in Makefile.in;
/cvsroot/mozilla/memory/jemalloc/Makefile.in,v  <--  Makefile.in
new revision: 1.4; previous revision: 1.3
done

Comment 8

[Dave Townsend [:mossop]]

That's some 20ms Ts regression :(

Comment 9

[Olli Pettay [:smaug][[e-mail]](vacation until Nov 16)]

This broke 64bit-Linux/Fedora7 builds, at least debug versions.
No problems in compilation, but when trying to start FF, I get the following error:
"Error: in (function call): procedure or syntax required but got: Error: fatal: looped fatal error"

I don't even know which library prints that out. Clobbering didn't help, until
I removed MOZ_MEMORY=1 from configure script.

Comment 10

[Olli Pettay [:smaug][[e-mail]](vacation until Nov 16)]

(In reply to comment #9)
> I removed MOZ_MEMORY=1 from configure script.
--disable-jemalloc has ofc the same effect.

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I cannot start Firefox trunk build without --disable-jemalloc if GTK_IM_MODULE=uim.
If it is GTK_IM_MODULE=xim, I can start fx. Should I file a new bug? And which component is suitable if I will file?

Comment 12

[Stuart Parmenter]

file a new bug, put stacks/etc in it.