41710 - psm-glue: PR_ASSERT() calls abort

Status: VERIFIED WONTFIX

(Core Graveyard :: Security: UI, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

in nsSSLIOLayer.cpp and nsPSMShimLayer.c, we have code that calls PR_ASSERT().

on linux, this calls abort(), and we exit the application.

it that the intended behaviour?

see bugs #41490 and #41704

two places where having a timebombed PSM caused a crash (abort()) instead of
failing gracefully.

I realize that with opt builds, PR_ASSERT() will not call abort, because the
pre-processor removes PR_ASSERT() in opt builds.

but can we fix this code to use NS_ASSERTION(), or something that won't call
abort?

Comment 1

[Doug Turner (:dougt)]

Reassigning all https/cartman/security bugs to valeski.  He will be finding new 
owner(s).  This shift is so that I can focus on embedding issues.  If the new 
owner has questions that can not be resovled, I may be able to lend a (quick) 
hand.

over to valeski....

Comment 2

[David P. Drinan]

Re-assigning all valeski PSM bugs to ddrinan.

Comment 3

[John Unruh]

rtm

Comment 4

[selmer (gone)]

rtm-, isn't it the case that release builds would not exhibit this behavior?

Comment 5

[(not reading, please use [e-mail] instead)]

right, release builds don't do this.  only developer builds.

rtm- is correct.

Comment 6

[John Unruh]

Is this bug relevant anymore?

Comment 7

[John Unruh]

Marking wontfix, now that PSM 2.0 is in process in the nightly builds.

Comment 8

[John Unruh]

Verified.

Comment 9

[John Unruh]

Mass changing Security:Crypto to PSM

Comment 10

[John Unruh]

Mass changing Security:Crypto to PSM