Closed Bug 417332 (moz2unit) Opened 12 years ago Closed 12 years ago

Need unit-test boxes for mozilla2

Categories

(Release Engineering :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: benjamin, Assigned: rcampbell)

References

Details

Attachments

(8 files, 4 obsolete files)

33.55 KB, patch
rcampbell
: review+
Details | Diff | Splinter Review
640 bytes, patch
bhearsum
: review+
Details | Diff | Splinter Review
6.33 KB, patch
coop
: review+
Details | Diff | Splinter Review
1.75 KB, patch
coop
: review+
Details | Diff | Splinter Review
38.69 KB, patch
bhearsum
: review+
Details | Diff | Splinter Review
3.18 KB, patch
bhearsum
: review+
Details | Diff | Splinter Review
7.40 KB, patch
Details | Diff | Splinter Review
5.39 KB, patch
bhearsum
: review+
Details | Diff | Splinter Review
Just as we're setting up build and talos boxes for moz2, we also need unit-test coverage. We should test mozilla-central and actionmonkey for the moment.
OS: Mac OS X → All
Priority: -- → P3
Hardware: PC → All
Assignee: nobody → rcampbell
Blocks: 422754
Assignee: rcampbell → nobody
Component: Testing → Release Engineering
Product: Core → mozilla.org
QA Contact: testing → release
Version: unspecified → other
Assignee: nobody → rcampbell
Priority: P3 → P2
Component: Release Engineering → Release Engineering: Projects
Component: Release Engineering: Projects → Release Engineering
Attached patch moz2 unittest first pass (obsolete) β€” β€” Splinter Review
a first crack at some moz2 unittest configuration files. Still using locally stored mozbuild.py file, waiting on a review in bug 418449 to split out to buildbotcustom. Linux and Mac only currently.
Depends on: 427566
Depends on: 427752
Depends on: 427991
To clarify, the part of this bug that blocks opening mozilla-central for checkins is getting mozilla-central unit test boxes that are the equivalent of the following tinderboxes on the Firefox tinderbox:

Linux qm-centos5-01 dep unit test
MacOSX Darwin 8.8.4 qm-xserve01 dep unit test
WINNT 5.2 qm-win2k3-01 dep unit test
Attached patch moz2 unittest second pass (obsolete) β€” β€” Splinter Review
this covers currently-running linux and mac moz2 unittest machines.
Attachment #312101 - Attachment is obsolete: true
Attachment #314836 - Flags: review?(bhearsum)
Comment on attachment 314836 [details] [diff] [review]
moz2 unittest second pass

>Index: master.cfg
>===================================================================
>+moz2_linux_unittest_factory.addStep(FileDownload, mastersrc='mozconfig-firefox-linux',
>+    slavedest='.mozconfig')

Two things here,
1) We talked about getting the unittest machines to inherit their mozconfigs from the build ones -- are we going to do that?
2) I think it's best if the mozconfig is pulled from version control. This very much reduces the PITA factor when you need to update it.


>Index: mozbuild.py
>===================================================================
>+            self.tboxClobberModule = 'mozilla/tools/tinderbox-configs/firefox/win32'
>+        else:
>+            self.tboxClobberModule = 'mozilla/tools/tinderbox-configs/firefox/' + self.platform
>+        if 'cvsroot' in kwargs:
>+            self.cvsroot = kwargs['cvsroot']
>+        if 'branch' in kwargs:
>+            self.branchString = ' -r ' + kwargs['branch']
>+            self.buildbotClobberModule = 'mozilla/tools/buildbot-configs/testing/unittest/CLOBBER/firefox/' + kwargs['branch'] + '/' + self.platform
>+        else:
>+            self.branchString = ''
>+            self.buildbotClobberModule = 'mozilla/tools/buildbot-configs/testing/unittest/CLOBBER/firefox/TRUNK/' + self.platform 
>+            

Are these paths valid for Moz2?


>Index: mozconfig-firefox-darwin
>===================================================================
>RCS file: mozconfig-firefox-darwin
>diff -N mozconfig-firefox-darwin
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ mozconfig-firefox-darwin	10 Apr 2008 13:14:43 -0000
>@@ -0,0 +1,5 @@
>+ac_add_options --enable-application=browser
>+mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/objdir
>+ac_add_options --enable-optimize="-Oz"
>+ac_add_options --disable-debug
>+ac_add_options --enable-tests

We're not using --enable-optimize on the Build OS X mozconfig -- let's remove that here, too.

>Index: mozconfig-firefox-linux
>===================================================================
>RCS file: mozconfig-firefox-linux
>diff -N mozconfig-firefox-linux
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ mozconfig-firefox-linux	10 Apr 2008 13:14:43 -0000
>@@ -0,0 +1,8 @@
>+ac_add_options --enable-application=browser
>+mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/objdir
>+ac_add_options --enable-optimize="-Os -gstabs+"
>+ac_add_options --disable-debug
>+ac_add_options --enable-tests
>+
>+CC=/tools/gcc/bin/gcc
>+CXX=/tools/gcc/bin/g++

No need for -gstabs+ here (looks like you took it from the Build mozconfig, though...so my bad).
Depends on: 428330
Sorry, I didn't really give a conclusion to the above review. r=bhearsum given the following:
1) mozconfig files are checked out from CVS or hg
2) the CLOBBER file path should be correct or removed entirely
This version has some Buildbot 0.7.7 compatibility changes, namely:
s/bots/slaves/ (and give c['slaves'] a list of BuildSlave instances)
s/sources/change_source/
s/Waterfall/WebStatus/

I also addressed my comments on the last patch - mozconfig files are checked out from CVS now and are more in line with the Build ones.

I added in a CVSROOT that is passed to 'python client.py checkout' - I don't think the default will work here.
Attachment #314836 - Attachment is obsolete: true
Attachment #315765 - Flags: review?(rcampbell)
Attachment #314836 - Flags: review?(bhearsum)
Comment on attachment 315765 [details] [diff] [review]
0.7.7 compatibility, address my own comments

now that's service! Thanks. :)
Attachment #315765 - Flags: review?(rcampbell) → review+
Depends on: 429332
Comment on attachment 315765 [details] [diff] [review]
0.7.7 compatibility, address my own comments

added to cvs for now, migrating to hg later.

RCS file: /cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/master.cfg,v
done
Checking in master.cfg;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/master.cfg,v  <--  master.cfg
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozbuild.py,v
done
Checking in mozbuild.py;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozbuild.py,v  <--  mozbuild.py
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-darwin,v
done
Checking in mozconfig-firefox-darwin;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-darwin,v  <--  mozconfig-firefox-darwin
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-linux,v
done
Checking in mozconfig-firefox-linux;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-linux,v  <--  mozconfig-firefox-linux
initial revision: 1.1
done
Attachment #315765 - Attachment filename: moz2unit.diff → [checked-in] moz2unit.diff
Alias: moz2unit
Attached patch moz2unit mozconfig darwin β€” β€” Splinter Review
updated with port autoconf options
Attachment #316832 - Flags: review?(bhearsum)
Attachment #316832 - Flags: review?(bhearsum) → review+
Priority: P2 → P1
Comment on attachment 316832 [details] [diff] [review]
moz2unit mozconfig darwin

Checking in mozconfig-firefox-darwin;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-darwin,v  <--  mozconfig-firefox-darwin
new revision: 1.2; previous revision: 1.1
done
Attachment #316832 - Attachment filename: moz2unit-mozconfig-darwin.diff → [checked-in] moz2unit-mozconfig-darwin.diff
Component: Release Engineering: Talos → Release Engineering
Depends on: 430279
renamed the unittest environment dictionaries. Also updated the windows2003 unittest dictionary to reflect the refplatform along with some other additions (D:\\Utilities, D:\\Mercurial).
Attachment #317555 - Flags: review?(ccooper)
Comment on attachment 317555 [details] [diff] [review]
modified envs for buildbot custom

Looks fine.
Attachment #317555 - Flags: review?(ccooper) → review+
Comment on attachment 317555 [details] [diff] [review]
modified envs for buildbot custom

Checking in env.py;
/cvsroot/mozilla/tools/buildbotcustom/env.py,v  <--  env.py
new revision: 1.7; previous revision: 1.6
done
Attachment #317555 - Attachment filename: bbotcustom3.patch → [checked-in] bbotcustom3.patch
small error in environment vars (INCLUDE section) and some adjusted spacing.
Attachment #317709 - Flags: review?(ccooper)
Attachment #317709 - Flags: review?(ccooper) → review+
Comment on attachment 317709 [details] [diff] [review]
buildbotcustom win2k3 unittest env patch

Checking in env.py;
/cvsroot/mozilla/tools/buildbotcustom/env.py,v  <--  env.py
new revision: 1.8; previous revision: 1.7
done
Attachment #317709 - Attachment filename: bbot-custom-env-fix.patch → [checked-in] bbot-custom-env-fix.patch
patch to buildbot custom's unittest steps to use
Attachment #318170 - Flags: review?(bhearsum)
... (hit submit before finishing thought) default profile instead of debug on windows.
Attached patch moz2 unittest windows steps (obsolete) β€” β€” Splinter Review
patch finally includes support for /tools/buildbotcustom classes. Removes mozbuild.py from local directory. Adds mozconfig-firefox-win32. Adds steps for win2k3 unittest machine.
Attachment #318176 - Flags: review?(bhearsum)
Comment on attachment 318170 [details] [diff] [review]
use default profile on windows for reftest

A fine patch.
Attachment #318170 - Flags: review?(bhearsum) → review+
Attachment #318176 - Flags: review?(bhearsum)
Comment on attachment 318176 [details] [diff] [review]
moz2 unittest windows steps

>Index: mozconfig-firefox-win2k3
>===================================================================
>+mk_add_options MOZ_CO_MODULE="mozilla/tools/update-packaging"
>+mk_add_options MOZ_PACKAGE_NSIS=1

Can probably drop these two - the former is for creating mars, the latter is for packaging.

>+ac_add_options --enable-update-channel=nightly

This can go.

>+ac_add_options --enable-update-packaging

This can go too.


r=bhearsum with those changes.
called the right steps for windows
Attachment #318176 - Attachment is obsolete: true
Attachment #318198 - Flags: review?(bhearsum)
Attachment #318198 - Flags: review?(bhearsum) → review+
fixes erroneous calling mechanism for MozillaWin32BrowserChromeTest, includes default profile fix.
Attachment #318170 - Attachment is obsolete: true
Attachment #318200 - Flags: review?(bhearsum)
Attachment #318200 - Flags: review?(bhearsum) → review+
Comment on attachment 318200 [details] [diff] [review]
profile + mochitest patch for buildbotcustom

Checking in unittest/steps.py;
/cvsroot/mozilla/tools/buildbotcustom/unittest/steps.py,v  <--  steps.py
new revision: 1.3; previous revision: 1.2
done
Attachment #318200 - Attachment filename: bbot-custom-win32-mochi.patch → [checked-in] bbot-custom-win32-mochi.patch
Comment on attachment 318198 [details] [diff] [review]
moz2 unittest windows steps v3

Checking in master.cfg;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/master.cfg,v  <--  master.cfg
new revision: 1.2; previous revision: 1.1
done
Removing mozbuild.py;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozbuild.py,v  <--  mozbuild.py
new revision: delete; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-win2k3,v
done
Checking in mozconfig-firefox-win2k3;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-win2k3,v  <--  mozconfig-firefox-win2k3
initial revision: 1.1
done
Attachment #318198 - Attachment filename: moz2-win32-3.patch → [checked-in] moz2-win32-3.patch
some fixes and tweaks, includes bhearsum's review comments regarding the win2k3 mozconfig. Currently running.
Comment on attachment 318279 [details] [diff] [review]
moz2 unittest mostly final

Checking in master.cfg;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/master.cfg,v  <--  master.cfg
new revision: 1.3; previous revision: 1.2
done
Checking in mozconfig-firefox-win2k3;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-win2k3,v  <--  mozconfig-firefox-win2k3
new revision: 1.2; previous revision: 1.1
done
Attachment #318279 - Attachment filename: moz2unit-near-final.patch → [checked-in] moz2unit-near-final.patch
Attached patch moz2 unittest production β€” β€” Splinter Review
move to production. Also removing -j compiler option which was generating warnings.
Attachment #318437 - Flags: review?(bhearsum)
Comment on attachment 318437 [details] [diff] [review]
moz2 unittest production

J'approuve
Attachment #318437 - Flags: review?(bhearsum) → review+
Comment on attachment 318437 [details] [diff] [review]
moz2 unittest production

Checking in master.cfg;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/master.cfg,v  <--  master.cfg
new revision: 1.4; previous revision: 1.3
done
Checking in mozconfig-firefox-win2k3;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-win2k3,v  <--  mozconfig-firefox-win2k3
new revision: 1.3; previous revision: 1.2
done
Attachment #318437 - Attachment filename: moz2-unittest-prod1.patch → [checked-in] moz2-unittest-prod1.patch
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.