417332 - (moz2unit) Need unit-test boxes for mozilla2

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[Benjamin Smedberg]

Just as we're setting up build and talos boxes for moz2, we also need unit-test coverage. We should test mozilla-central and actionmonkey for the moment.

Comment 2

[Rob Campbell [:rc] (:robcee)]

Attachment: moz2 unittest first pass

a first crack at some moz2 unittest configuration files. Still using locally stored mozbuild.py file, waiting on a review in bug 418449 to split out to buildbotcustom. Linux and Mac only currently.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

To clarify, the part of this bug that blocks opening mozilla-central for checkins is getting mozilla-central unit test boxes that are the equivalent of the following tinderboxes on the Firefox tinderbox:

Linux qm-centos5-01 dep unit test
MacOSX Darwin 8.8.4 qm-xserve01 dep unit test
WINNT 5.2 qm-win2k3-01 dep unit test

Comment 4

[Rob Campbell [:rc] (:robcee)]

Attachment: moz2 unittest second pass

this covers currently-running linux and mac moz2 unittest machines.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 314836 [details] [diff] [review]
moz2 unittest second pass

>Index: master.cfg
>===================================================================
>+moz2_linux_unittest_factory.addStep(FileDownload, mastersrc='mozconfig-firefox-linux',
>+    slavedest='.mozconfig')

Two things here,
1) We talked about getting the unittest machines to inherit their mozconfigs from the build ones -- are we going to do that?
2) I think it's best if the mozconfig is pulled from version control. This very much reduces the PITA factor when you need to update it.


>Index: mozbuild.py
>===================================================================
>+            self.tboxClobberModule = 'mozilla/tools/tinderbox-configs/firefox/win32'
>+        else:
>+            self.tboxClobberModule = 'mozilla/tools/tinderbox-configs/firefox/' + self.platform
>+        if 'cvsroot' in kwargs:
>+            self.cvsroot = kwargs['cvsroot']
>+        if 'branch' in kwargs:
>+            self.branchString = ' -r ' + kwargs['branch']
>+            self.buildbotClobberModule = 'mozilla/tools/buildbot-configs/testing/unittest/CLOBBER/firefox/' + kwargs['branch'] + '/' + self.platform
>+        else:
>+            self.branchString = ''
>+            self.buildbotClobberModule = 'mozilla/tools/buildbot-configs/testing/unittest/CLOBBER/firefox/TRUNK/' + self.platform 
>+            

Are these paths valid for Moz2?


>Index: mozconfig-firefox-darwin
>===================================================================
>RCS file: mozconfig-firefox-darwin
>diff -N mozconfig-firefox-darwin
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ mozconfig-firefox-darwin	10 Apr 2008 13:14:43 -0000
>@@ -0,0 +1,5 @@
>+ac_add_options --enable-application=browser
>+mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/objdir
>+ac_add_options --enable-optimize="-Oz"
>+ac_add_options --disable-debug
>+ac_add_options --enable-tests

We're not using --enable-optimize on the Build OS X mozconfig -- let's remove that here, too.

>Index: mozconfig-firefox-linux
>===================================================================
>RCS file: mozconfig-firefox-linux
>diff -N mozconfig-firefox-linux
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ mozconfig-firefox-linux	10 Apr 2008 13:14:43 -0000
>@@ -0,0 +1,8 @@
>+ac_add_options --enable-application=browser
>+mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/objdir
>+ac_add_options --enable-optimize="-Os -gstabs+"
>+ac_add_options --disable-debug
>+ac_add_options --enable-tests
>+
>+CC=/tools/gcc/bin/gcc
>+CXX=/tools/gcc/bin/g++

No need for -gstabs+ here (looks like you took it from the Build mozconfig, though...so my bad).

Comment 6

[[e-mail] (:bhearsum)]

Sorry, I didn't really give a conclusion to the above review. r=bhearsum given the following:
1) mozconfig files are checked out from CVS or hg
2) the CLOBBER file path should be correct or removed entirely

Comment 7

[[e-mail] (:bhearsum)]

Attachment: 0.7.7 compatibility, address my own comments

This version has some Buildbot 0.7.7 compatibility changes, namely:
s/bots/slaves/ (and give c['slaves'] a list of BuildSlave instances)
s/sources/change_source/
s/Waterfall/WebStatus/

I also addressed my comments on the last patch - mozconfig files are checked out from CVS now and are more in line with the Build ones.

I added in a CVSROOT that is passed to 'python client.py checkout' - I don't think the default will work here.

Comment 8

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 315765 [details] [diff] [review]
0.7.7 compatibility, address my own comments

now that's service! Thanks. :)

Comment 9

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 315765 [details] [diff] [review]
0.7.7 compatibility, address my own comments

added to cvs for now, migrating to hg later.

RCS file: /cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/master.cfg,v
done
Checking in master.cfg;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/master.cfg,v  <--  master.cfg
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozbuild.py,v
done
Checking in mozbuild.py;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozbuild.py,v  <--  mozbuild.py
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-darwin,v
done
Checking in mozconfig-firefox-darwin;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-darwin,v  <--  mozconfig-firefox-darwin
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-linux,v
done
Checking in mozconfig-firefox-linux;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-linux,v  <--  mozconfig-firefox-linux
initial revision: 1.1
done

Comment 10

[Rob Campbell [:rc] (:robcee)]

Attachment: moz2unit mozconfig darwin

updated with port autoconf options

Comment 11

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 316832 [details] [diff] [review]
moz2unit mozconfig darwin

Checking in mozconfig-firefox-darwin;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-darwin,v  <--  mozconfig-firefox-darwin
new revision: 1.2; previous revision: 1.1
done

Comment 12

[Rob Campbell [:rc] (:robcee)]

Attachment: modified envs for buildbot custom

renamed the unittest environment dictionaries. Also updated the windows2003 unittest dictionary to reflect the refplatform along with some other additions (D:\\Utilities, D:\\Mercurial).

Comment 13

[Chris Cooper [:coop] (he/him)]

Comment on attachment 317555 [details] [diff] [review]
modified envs for buildbot custom

Looks fine.

Comment 14

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 317555 [details] [diff] [review]
modified envs for buildbot custom

Checking in env.py;
/cvsroot/mozilla/tools/buildbotcustom/env.py,v  <--  env.py
new revision: 1.7; previous revision: 1.6
done

Comment 15

[Rob Campbell [:rc] (:robcee)]

Attachment: buildbotcustom win2k3 unittest env patch

small error in environment vars (INCLUDE section) and some adjusted spacing.

Comment 16

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 317709 [details] [diff] [review]
buildbotcustom win2k3 unittest env patch

Checking in env.py;
/cvsroot/mozilla/tools/buildbotcustom/env.py,v  <--  env.py
new revision: 1.8; previous revision: 1.7
done

Comment 17

[Rob Campbell [:rc] (:robcee)]

Attachment: use default profile on windows for reftest

patch to buildbot custom's unittest steps to use

Comment 18

[Rob Campbell [:rc] (:robcee)]

... (hit submit before finishing thought) default profile instead of debug on windows.

Comment 19

[Rob Campbell [:rc] (:robcee)]

Attachment: moz2 unittest windows steps

patch finally includes support for /tools/buildbotcustom classes. Removes mozbuild.py from local directory. Adds mozconfig-firefox-win32. Adds steps for win2k3 unittest machine.

Comment 20

[[e-mail] (:bhearsum)]

Comment on attachment 318170 [details] [diff] [review]
use default profile on windows for reftest

A fine patch.

Comment 21

[[e-mail] (:bhearsum)]

Comment on attachment 318176 [details] [diff] [review]
moz2 unittest windows steps

>Index: mozconfig-firefox-win2k3
>===================================================================
>+mk_add_options MOZ_CO_MODULE="mozilla/tools/update-packaging"
>+mk_add_options MOZ_PACKAGE_NSIS=1

Can probably drop these two - the former is for creating mars, the latter is for packaging.

>+ac_add_options --enable-update-channel=nightly

This can go.

>+ac_add_options --enable-update-packaging

This can go too.


r=bhearsum with those changes.

Comment 22

[Rob Campbell [:rc] (:robcee)]

Attachment: moz2 unittest windows steps v3

called the right steps for windows

Comment 23

[Rob Campbell [:rc] (:robcee)]

Attachment: profile + mochitest patch for buildbotcustom

fixes erroneous calling mechanism for MozillaWin32BrowserChromeTest, includes default profile fix.

Comment 24

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 318200 [details] [diff] [review]
profile + mochitest patch for buildbotcustom

Checking in unittest/steps.py;
/cvsroot/mozilla/tools/buildbotcustom/unittest/steps.py,v  <--  steps.py
new revision: 1.3; previous revision: 1.2
done

Comment 25

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 318198 [details] [diff] [review]
moz2 unittest windows steps v3

Checking in master.cfg;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/master.cfg,v  <--  master.cfg
new revision: 1.2; previous revision: 1.1
done
Removing mozbuild.py;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozbuild.py,v  <--  mozbuild.py
new revision: delete; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-win2k3,v
done
Checking in mozconfig-firefox-win2k3;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-win2k3,v  <--  mozconfig-firefox-win2k3
initial revision: 1.1
done

Comment 26

[Rob Campbell [:rc] (:robcee)]

Attachment: moz2 unittest mostly final

some fixes and tweaks, includes bhearsum's review comments regarding the win2k3 mozconfig. Currently running.

Comment 27

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 318279 [details] [diff] [review]
moz2 unittest mostly final

Checking in master.cfg;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/master.cfg,v  <--  master.cfg
new revision: 1.3; previous revision: 1.2
done
Checking in mozconfig-firefox-win2k3;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-win2k3,v  <--  mozconfig-firefox-win2k3
new revision: 1.2; previous revision: 1.1
done

Comment 28

[Rob Campbell [:rc] (:robcee)]

Attachment: moz2 unittest production

move to production. Also removing -j compiler option which was generating warnings.

Comment 29

[[e-mail] (:bhearsum)]

Comment on attachment 318437 [details] [diff] [review]
moz2 unittest production

J'approuve

Comment 30

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 318437 [details] [diff] [review]
moz2 unittest production

Checking in master.cfg;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/master.cfg,v  <--  master.cfg
new revision: 1.4; previous revision: 1.3
done
Checking in mozconfig-firefox-win2k3;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-win2k3,v  <--  mozconfig-firefox-win2k3
new revision: 1.3; previous revision: 1.2
done