Closed
Bug 417399
Opened 17 years ago
Closed 16 years ago
Arena Allocation results are not checked in pkix_pl_InfoAccess_ParseLocation
Categories
(NSS :: Libraries, defect, P1)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
3.12.1
People
(Reporter: alvolkov.bgs, Assigned: alvolkov.bgs)
Details
(Whiteboard: PKIX)
Attachments
(1 file)
3.41 KB,
patch
|
nelson
:
review+
|
Details | Diff | Splinter Review |
The function also leaks memory if parsing error occurs.
Assignee | ||
Updated•17 years ago
|
Whiteboard: PKIX
Assignee | ||
Updated•17 years ago
|
Priority: -- → P2
Updated•16 years ago
|
Priority: P2 → P1
Summary: Allocation results are not checked in pkix_pl_InfoAccess_ParseLocation → Arena Allocation results are not checked in pkix_pl_InfoAccess_ParseLocation
Target Milestone: 3.12 → 3.12.1
Assignee | ||
Comment 1•16 years ago
|
||
Attachment #326578 -
Flags: review?(nelson)
Comment 2•16 years ago
|
||
Comment on attachment 326578 [details] [diff] [review] Patch v1 - check pointer for NULL after allocation This patch is good, as far as it goes. While you're at it, some of these PORT_ArenaZAlloc calls should be changed to PORT_ArenaZNewArray calls. Please make the changes indicated below. >- PKIX_PL_NSSCALLRV >- (INFOACCESS, *tokens, PORT_ArenaZAlloc, >- (arena, (numFilters+1)*sizeof(void *))); >+ filterP = PORT_ArenaZAlloc(arena, (numFilters+1)*sizeof(void *)); filterP = PORT_ArenaZNewArray(arena, void *, numFilters+1); > /* Get room for null-terminated array of (LdapNameComponent *) */ >- PKIX_PL_NSSCALLRV >- (INFOACCESS, v, PORT_ArenaZAlloc, >- (arena, len*sizeof(LDAPNameComponent *))); >+ v = PORT_ArenaZAlloc(arena, len*sizeof(LDAPNameComponent *)); >+ if (v == NULL) { >+ PKIX_ERROR(PKIX_PORTARENAALLOCFAILED); >+ } > > setOfNameComponent = (LDAPNameComponent **)v; There's no need to use a void * in the above code. Those lines above should be: setOfNameComponent = PORT_ArenaZNewArray(arena, LDAPNameComponent *, len); if (!setOfNameComponent) PKIX_ERROR(PKIX_PORTARENAALLOCFAILED); > /* Get room for the remaining LdapNameComponents */ >- PKIX_PL_NSSCALLRV >- (INFOACCESS, v, PORT_ArenaZNewArray, >- (arena, LDAPNameComponent, --len)); >+ v = PORT_ArenaZNewArray(arena, LDAPNameComponent, --len); >+ if (v == NULL) { >+ PKIX_ERROR(PKIX_PORTARENAALLOCFAILED); >+ } > > nameComponent = (LDAPNameComponent *)v; There's no need to use a void * in the above code. PORT_ArenaZNewArray already returns a pointer of type (LDAPNameComponent *) so, make that code be the much clearer nameComponent = PORT_ArenaZNewArray(arena, LDAPNameComponent, --len); if (!nameComponent) PKIX_ERROR(PKIX_PORTARENAALLOCFAILED);
Attachment #326578 -
Flags: review?(nelson) → review+
Assignee | ||
Comment 3•16 years ago
|
||
Thanks for the review. Patch and suggested changes have been integrated.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•