417429 - js-errors when trying to Compose E-Mail to Attendees from Sunbird

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Sven Giermann]

Attendees in Sunbird's event show the ability to Compose E-Mail in context menu, but this does not work and produces an error in Javascript console:

Error: uncaught exception: [Exception... "Component returned failure code: 0x804b000a [nsIIOService.newURI]"  nsresult: "0x804b000a (<unknown>)"  location: "JS frame :: chrome://calendar/content/calUtils.js :: sendMailTo :: line 1736"  data: no]

Comment 1

[Sven Giermann]

The decision, whether to remove these menu items or to add the checkbox "Send mail invitations" (like in Lightning) has to be done by UI-Team...

Comment 2

[Stefan Sitter [:ssitter]]

If I remember correctly this used to work. Could you narrow down the regression range?

Comment 3

[Stefan Sitter [:ssitter]]

Confirmed as regression:
  Works in Sunbird 0.8pre (2007-12-14-03)
  Fails in Sunbird 0.8pre (2007-12-15-05)
    
Checkins during regression range: http://tinyurl.com/2jjboz

--> Regressed by the checkin from Bug 388018

Comment 4

[Sven Giermann]

Attachment: Correcting simple cut&paste error...

Stefan, thanks for doing most of the work!

This one is quite obvious.
Since Mickey currently does no reviews, I chose Daniel...

Comment 5

[Stefan Sitter [:ssitter]]

(In reply to bug 388018 comment #17)
> (In reply to bug 388018 comment #16)
> >-        var uriString = "mailto:" + aRecipient;
> >+        var uriString = "";
> >         var uriParams = [];
> >+        if (!aRecipient || aRecipient.length < 1) {
> >+            uriString = "mailto:" + aRecipient;
> >+        }
> The purpose was to make the function sendMailTo() allow sending
> mails without being forced to specify a dedicated recipient.
> Assume we drop an event without an organizer onto the mail
> button, in this case the mail compose window should come up
> with an empty recipient field. Without the above change,
> sendMailTo() just silently failed.

We are only reaching this branch if we are in Sunbird and want to call the systems mailto: protocol handler. In this case a valid recipient is required. In my opinion we need to exit this branch early if no recipient is specified - as it was before the checkin from bug 388018.

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 303481 [details] [diff] [review]
Correcting simple cut&paste error...

daniel is on vacation

Comment 7

[Stefan Sitter [:ssitter]]

Comment on attachment 303481 [details] [diff] [review]
Correcting simple cut&paste error...

From a quick test it seems that something like "mailto:?subject=test" or even "mailto:" also works. This means uriString must be initialized to "mailto:". If a recipient is passed it should be added.

Comment 8

[Sven Giermann]

Attachment: Patch v2, enabling empty recipient

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 303508 [details] [diff] [review]
Patch v2, enabling empty recipient

Looks good, r=philipp

Comment 10

[Philipp Kewisch [:Fallen][📱📆]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED