Closed Bug 417476 Opened 17 years ago Closed 17 years ago

This Frame context submenu needs menu icons

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3 beta4

People

(Reporter: adelfino, Assigned: reed)

References

Details

Attachments

(2 files)

Screenshot showing no icons in the menu.
7.83 KB, image/png
Details
patch - v1
6.65 KB, patch
rflint
: review+
damons
: approval1.9+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008021405 Minefield/3.0b4pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008021405 Minefield/3.0b4pre

This frame context submenu needs menu icons.

Firefox main window menus has icons that can (and should) be used in This Frame context submenu:

Open Frame in New Window
Open Frame in New Tab
Reload Frame
Bookmark This Frame
Save Frame As...
Print Frame...
View Frame Info

Reproducible: Always
Severity: normal → trivial
Component: Menus → Theme
Version: unspecified → Trunk

  

  


QA Contact: menus → theme

    
  
Blocks: 405165
Status: UNCONFIRMED → NEW
Ever confirmed: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch - v1
        — 
          — Splinter Review
      

    


  

  

  


Assignee: nobody → reed
Status: NEW → ASSIGNED

        Attachment #305735 -
        Flags: review?(rflint)

        Attachment #305735 -
        Flags: review?(rflint) → review+

    
    

    
  
Comment on attachment 305735 [details] [diff] [review]
patch - v1

mpa=mano.

  

  



    
  

        Attachment #305735 -
        Flags: approval1.9?

    
    

    
  
Comment on attachment 305735 [details] [diff] [review]
patch - v1

a1.9+=damons

  

  



        Attachment #305735 -
        Flags: approval1.9? → approval1.9+

    
  
Keywords: checkin-needed

    
    

    
  
Checking in browser/base/content/browser-context.inc;
/cvsroot/mozilla/browser/base/content/browser-context.inc,v  <--  browser-context.inc
new revision: 1.40; previous revision: 1.39
done
Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v  <--  browser.css
new revision: 1.194; previous revision: 1.193
done

  

  


Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta4

    
  
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: