417560 - protect against Obj-C exceptions in "gfx" top-level directory

Status: RESOLVED INCOMPLETE

(Core Graveyard :: GFX, defect, P2)

Description

[Josh Aas]

For implementing the strategy we decided on in bug 163260 we are filing a bug for each top-level directory that needs work.

mozilla/gfx

Comment 1

[John Daggett (:jtd)]

What's the right solution for gfxQuartzFontCache.mm? Stan noted that it's compiled with exceptions disabled (bug 163260 comment 116).

Comment 2

[Stan Shebs]

#undef'ing try and catch at the top of the file is a hack, but on the plus side, it will give future generations a good laugh.

You could try to suppress the -fno-exceptions to the file, that seems like more trouble than it's worth.

Comment 3

[Josh Aas]

-fno-exceptions is defined for a lot of stuff, including all of cocoa widgets. Do we really care about it? Does it interfere with the obj-c exception stuff?

Comment 4

[Josh Aas]

Attachment: why doesn't this compile?

We can't compile in gfx with obj-c exception handlers. This patch implements exception wrapping in one place to demonstrate the compile failure.

Comment 5

[Josh Aas]

Attachment: compiler failure output

This is the output for the failure.

Comment 6

[Josh Aas]

Security concerns over this don't warrant blocking 1.9, but will take a patch at any time.

Comment 7

[Brandon Sterne (:bsterne)]

Hey Josh.  This is still blocking bug 163260.  Have you been able to make any progress?

Comment 8

[Damon Sicore (:damons)]

Also, what about 1.9.0.x vs 1.9.1?

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Is this bug really dead, or should it live in Gfx:Thebes instead of Core Graveyard?

Comment 10

[:Irving Reid (No longer working on Firefox)]

We have seen some recent crashes in Thunderbird that trace back to Obj-C exceptions thrown under gfx; see

http://crash-stats.mozilla.com/report/index/bp-14415bc8-3ff5-4105-9767-581552120919
http://crash-stats.mozilla.com/report/index/bp-908ca17d-a0e6-4173-b992-5d3b82120919
http://crash-stats.mozilla.com/report/index/bp-f1b344f3-e7d0-4e28-a996-79db32120919

https://bugzilla.mozilla.org/show_bug.cgi?id=790234#c3