417583 - Find updates button needs disabling/hiding in some contexts

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Dave Townsend [:mossop]]

We can never find updates in hte plugins pane so it should probably be hidden here. Bug 415820 suggests that we should disable it when the browser if marked offline. We already disable it when there are no items in view that can be updated (default theme/extensions f.e.).

We should make some call on when to show/hide/disable this button that doesn't become too confusing for the user.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

We probably want separate bugs for each of the issues we decide on.

I'm blocking on having it hidden for plugins, since we can never update any content in that view.

In cases where we can *sometimes* offer updates, it should be shown on items which can, potentially, be updated, and disabled in cases when that function is unavailable. (So by this heuristic, it would never appear on the default theme, but would appear on other themes)

Comment 2

[Madhava Enros [:madhava]]

We should definitely not show it on the Plugins page, given that it cannot be enabled (which is worse than simply not being useful - it's actively misleading).

I think the current enabled/disabled behavior on the Extensions, Themes, etc. pages works fine.  They're disabled by default at first, but that's consistent with there being nothing that can be updated at that moment, and they then activate at the appropriate time.

Comment 3

[Dave Townsend [:mossop]]

Attachment: no-brainer

Per UX just hide the button on the plugins view and leave the rest as is.

Comment 4

[Dave Townsend [:mossop]]

Checking in toolkit/mozapps/extensions/content/extensions.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.js,v  <--  extensions.js
new revision: 1.162; previous revision: 1.161
done

Comment 5

[Marcia Knous [:marcia]]

Verified fixed in Plugins using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4pre) Gecko/2008022604 Minefield/3.0b4pre, Win XP and Linux nightly. Find Updates is not shown in the Plugins tab.